Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

GeckoView update (nightly) (20190926-142132) #4545

Merged
merged 1 commit into from
Sep 26, 2019
Merged

GeckoView update (nightly) (20190926-142132) #4545

merged 1 commit into from
Sep 26, 2019

Conversation

MickeyMoz
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #4545 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4545      +/-   ##
============================================
- Coverage     81.45%   81.29%   -0.16%     
+ Complexity     4073     2943    -1130     
============================================
  Files           533      410     -123     
  Lines         17992    13385    -4607     
  Branches       2660     1892     -768     
============================================
- Hits          14656    10882    -3774     
+ Misses         2265     1744     -521     
+ Partials       1071      759     -312
Impacted Files Coverage Δ Complexity Δ
...ponents/service/experiments/ExperimentEvaluator.kt 85.57% <0%> (-0.97%) 57% <0%> (-1%)
...nents/feature/prompts/widget/MonthAndYearPicker.kt
...ponents/feature/sitepermissions/SitePermissions.kt
...lla/components/browser/state/state/BrowserState.kt
...s/support/android/test/espresso/ViewInteraction.kt
...e/sitepermissions/SitePermissionsDialogFragment.kt
.../mozilla/components/support/utils/DrawableUtils.kt
.../components/feature/prompts/AlertDialogFragment.kt
...nents/browser/state/reducer/ContentStateReducer.kt
...ozilla/components/feature/prompts/ChoiceAdapter.kt
... and 116 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 317e7c7...69f0b59. Read the comment docs.

Copy link
Contributor

@pocmo pocmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Sep 26, 2019
4395: Uplift Theme.resolveAttribute from Fenix r=pocmo a=NotWoods

Uplifts functions from Fenix to get a color int from a theme.



4542:  Public Suffix List update (20190926-142145) r=pocmo a=MickeyMoz



4544:  GeckoView update (beta) (20190926-142130) r=pocmo a=MickeyMoz



4545:  GeckoView update (nightly) (20190926-142132) r=pocmo a=MickeyMoz



4547: Hide custom tab close button in PWAs r=jonalmeida a=NotWoods

The close button destroys the entire PWA, which isn't what we want. Let's hide the button for now.



Co-authored-by: Tiger Oakes <toakes@mozilla.com>
Co-authored-by: MickeyMoz <sebastian@mozilla.com>
@bors
Copy link

bors bot commented Sep 26, 2019

Timed out (retrying...)

bors bot pushed a commit that referenced this pull request Sep 26, 2019
4544:  GeckoView update (beta) (20190926-142130) r=pocmo a=MickeyMoz



4545:  GeckoView update (nightly) (20190926-142132) r=pocmo a=MickeyMoz



4547: Hide custom tab close button in PWAs r=jonalmeida a=NotWoods

The close button destroys the entire PWA, which isn't what we want. Let's hide the button for now.



Co-authored-by: MickeyMoz <sebastian@mozilla.com>
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
@bors
Copy link

bors bot commented Sep 26, 2019

Build succeeded

@bors bors bot merged commit 69f0b59 into mozilla-mobile:master Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants