Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Closes #8240: Only dismiss prompts that are not already dismissed #8244

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Closes #8240: Only dismiss prompts that are not already dismissed #8244

merged 1 commit into from
Aug 28, 2020

Conversation

Amejia481
Copy link
Contributor

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@Amejia481 Amejia481 added the 🕵️‍♀️ needs review PRs that need to be reviewed label Aug 26, 2020
@Amejia481 Amejia481 linked an issue Aug 28, 2020 that may be closed by this pull request
SharePrompt: RuntimeException Cannot confirm/dismiss a Prompt twice #8240
Closed
rocketsroger
rocketsroger approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@rocketsroger rocketsroger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rocketsroger rocketsroger added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Aug 28, 2020
@Amejia481
Copy link
Contributor Author

bors r=rocketsroger

@bors
Copy link

bors bot commented Aug 28, 2020

Build succeeded:

@bors bors bot merged commit 8d092d1 into mozilla-mobile:master Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rocketsroger rocketsroger rocketsroger approved these changes

Assignees
No one assigned
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SharePrompt: RuntimeException Cannot confirm/dismiss a Prompt twice
2 participants
@Amejia481 @rocketsroger