Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Closes issue #8367: Add SHIMMED TrackingCategory #8630

Merged
merged 2 commits into from
Oct 7, 2020

Conversation

Amejia481
Copy link
Contributor

As we are now using the shims library from the web compact extension, we need to exposed this new category for apps to be aware that some resources can be replaced with shimmed files instead of been blocked. You can find more info in the Fenix related issue mozilla-mobile/fenix#14071

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@Amejia481 Amejia481 added the 🕵️‍♀️ needs review PRs that need to be reviewed label Oct 6, 2020
@Amejia481 Amejia481 requested a review from csadilek October 6, 2020 20:33
@Amejia481 Amejia481 force-pushed the issue-8367 branch 3 times, most recently from c921953 to 0a94134 Compare October 6, 2020 23:08
@Amejia481 Amejia481 closed this Oct 6, 2020
@Amejia481 Amejia481 reopened this Oct 6, 2020
@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2020

This pull request has conflicts when rebasing. Could you fix it @Amejia481? 🙏

@Amejia481
Copy link
Contributor Author

This pull request has conflicts when rebasing. Could you fix it @Amejia481? 🙏

Ready :)

Copy link
Contributor

@csadilek csadilek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit to clarify API. 👍

@Amejia481 Amejia481 added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Oct 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants