-
Notifications
You must be signed in to change notification settings - Fork 473
Issue #9801: Refactor AutofillCreditCardsAddressesStorage into its own :service-sync-autofill component #9848
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add an entry to taskcluster/ci/config.yml
as well when you add a new project in the .buildconfig.yml
file.
@@ -2,7 +2,7 @@ | |||
* License, v. 2.0. If a copy of the MPL was not distributed with this | |||
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | |||
|
|||
package mozilla.components.browser.storage.sync | |||
package mozilla.components.service.sync.autofill |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the Gecko delegate live in the browser-engine-gecko-*
components?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't actually the delegate wrapper around GV's Autcomplete (yet to be landed yet). We would add something equivalent to GeckoLoginDelegateWrapper
in browser-engine-gecko-*
. This is equivalent to GeckoLoginStorageDelegate
, but you could be right since this needs to be attached to the runtime.
I don't know enough about the specifics of where this should live, but if we determine both GeckoLoginStorageDelegate
and this file should be in browser-engine-gecko-*
, let's file a new issue and move them both there.
Codecov Report
@@ Coverage Diff @@
## master #9848 +/- ##
============================================
- Coverage 74.05% 68.22% -5.83%
+ Complexity 5655 531 -5124
============================================
Files 772 76 -696
Lines 28766 3163 -25603
Branches 4738 500 -4238
============================================
- Hits 21303 2158 -19145
+ Misses 4986 734 -4252
+ Partials 2477 271 -2206
Continue to review full report at Codecov.
|
…ge into its own :service-sync-autofill component
Fixes #9801
Pull Request checklist
After merge