For #15366: Add recently closed tabs metrics from history fragment.

mozilla-mobile · Dec 10, 2020 · 262a72f · 262a72f
1 parent 1972a16
commit 262a72f
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/app/src/main/java/org/mozilla/fenix/library/history/HistoryController.kt b/app/src/main/java/org/mozilla/fenix/library/history/HistoryController.kt
@@ -15,6 +15,8 @@ import mozilla.components.concept.engine.prompt.ShareData
 import org.mozilla.fenix.R
 import org.mozilla.fenix.browser.browsingmode.BrowsingMode
 import org.mozilla.fenix.components.FenixSnackbar
+import org.mozilla.fenix.components.metrics.Event
+import org.mozilla.fenix.components.metrics.MetricController
 
 @Suppress("TooManyFunctions")
 interface HistoryController {
@@ -43,7 +45,8 @@ class DefaultHistoryController(
     private val displayDeleteAll: () -> Unit,
     private val invalidateOptionsMenu: () -> Unit,
     private val deleteHistoryItems: (Set<HistoryItem>) -> Unit,
-    private val syncHistory: suspend () -> Unit
+    private val syncHistory: suspend () -> Unit,
+    private val metrics: MetricController
 ) : HistoryController {
     override fun handleOpen(item: HistoryItem, mode: BrowsingMode?) {
         openToBrowser(item, mode)
@@ -111,5 +114,6 @@ class DefaultHistoryController(
             HistoryFragmentDirections.actionGlobalRecentlyClosed(),
             NavOptions.Builder().setPopUpTo(R.id.recentlyClosedFragment, true).build()
         )
+        metrics.track(Event.RecentlyClosedTabsOpened)
     }
 }
diff --git a/app/src/main/java/org/mozilla/fenix/library/history/HistoryFragment.kt b/app/src/main/java/org/mozilla/fenix/library/history/HistoryFragment.kt
@@ -92,8 +92,9 @@ class HistoryFragment : LibraryPageFragment<HistoryItem>(), UserInteractionHandl
             ::displayDeleteAllDialog,
             ::invalidateOptionsMenu,
             ::deleteHistoryItems,
-            ::syncHistory
-        )
+            ::syncHistory,
+            requireComponents.analytics.metrics
+            )
         historyInteractor = HistoryInteractor(
             historyController
         )

diff --git a/app/src/test/java/org/mozilla/fenix/library/history/HistoryControllerTest.kt b/app/src/test/java/org/mozilla/fenix/library/history/HistoryControllerTest.kt
@@ -25,6 +25,7 @@ import org.junit.Test
 import org.junit.runner.RunWith
 import org.mozilla.fenix.browser.browsingmode.BrowsingMode
 import org.mozilla.fenix.components.FenixSnackbar
+import org.mozilla.fenix.components.metrics.MetricController
 import org.mozilla.fenix.ext.directionsEq
 import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
 
@@ -45,6 +46,7 @@ class HistoryControllerTest {
     private val invalidateOptionsMenu: () -> Unit = mockk(relaxed = true)
     private val deleteHistoryItems: (Set<HistoryItem>) -> Unit = mockk(relaxed = true)
     private val syncHistory: suspend () -> Unit = mockk(relaxed = true)
+    private val metrics: MetricController = mockk(relaxed = true)
     private val controller = DefaultHistoryController(
         store,
         navController,
@@ -56,7 +58,8 @@ class HistoryControllerTest {
         displayDeleteAll,
         invalidateOptionsMenu,
         deleteHistoryItems,
-        syncHistory
+        syncHistory,
+        metrics
     )
 
     @Before