For #24715: Remove obsolete addon installed metric.

mozilla-mobile · Apr 12, 2022 · 3c8e539 · 3c8e539
1 parent b0c5148
commit 3c8e539
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 6 deletions.
diff --git a/app/src/main/java/org/mozilla/fenix/addons/AddonsManagementFragment.kt b/app/src/main/java/org/mozilla/fenix/addons/AddonsManagementFragment.kt
@@ -30,11 +30,9 @@ import org.mozilla.fenix.BuildConfig
 import org.mozilla.fenix.Config
 import org.mozilla.fenix.R
 import org.mozilla.fenix.components.FenixSnackbar
-import org.mozilla.fenix.components.metrics.Event
 import org.mozilla.fenix.databinding.FragmentAddOnsManagementBinding
 import org.mozilla.fenix.ext.components
 import org.mozilla.fenix.ext.getRootView
-import org.mozilla.fenix.ext.requireComponents
 import org.mozilla.fenix.ext.settings
 import org.mozilla.fenix.ext.showToolbar
 import org.mozilla.fenix.ext.runIfFragmentIsAttached
@@ -231,7 +229,6 @@ class AddonsManagementFragment : Fragment(R.layout.fragment_add_ons_management)
 
     private fun showInstallationDialog(addon: Addon) {
         if (!isInstallationInProgress && !hasExistingAddonInstallationDialogFragment()) {
-            requireComponents.analytics.metrics.track(Event.AddonInstalled(addon.id))
             val context = requireContext()
             val addonCollectionProvider = context.components.addonCollectionProvider
 

diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt
@@ -229,8 +229,6 @@ sealed class Event {
         }
     }
 
-    data class AddonInstalled(val addonId: String) : Event()
-
     object AutoPlaySettingVisited : Event()
 
     data class AutoPlaySettingChanged(val setting: AutoplaySetting) : Event() {

diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt
@@ -410,7 +410,6 @@ private val Event.wrapper: EventWrapper<*>?
         is Event.InteractWithSearchURLArea -> null
         is Event.ClearedPrivateData -> null
         is Event.DismissedOnboarding -> null
-        is Event.AddonInstalled -> null
         is Event.SearchWidgetInstalled -> null
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -229,8 +229,6 @@ sealed class Event { @@
             }
         }
-        data class AddonInstalled(val addonId: String) : Event()
         object AutoPlaySettingVisited : Event()
         data class AutoPlaySettingChanged(val setting: AutoplaySetting) : Event() {
@@ Expand Down @@