Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Commit

Permalink
For #26551 - Add telemetry for MR Onboarding welcome and sync dialogs.
Browse files Browse the repository at this point in the history
  • Loading branch information
Alexandru2909 committed Aug 23, 2022
1 parent 8cd13a5 commit 8bef183
Show file tree
Hide file tree
Showing 2 changed files with 139 additions and 3 deletions.
114 changes: 114 additions & 0 deletions app/metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,120 @@ onboarding:
metadata:
tags:
- Onboarding
welcome_card_impression:
type: event
description:
The welcome onboarding card was displayed to the user.
bugs:
- https://github.com/mozilla-mobile/fenix/issues/26551
data_reviews:
- https://github.com/mozilla-mobile/fenix/pull/TODO
data_sensitivity:
- interaction
notification_emails:
- android-probes@mozilla.com
expires: 119
metadata:
tags:
- Onboarding
welcome_close_clicked:
type: event
description:
The user clicked the `X` button from the welcome onboarding card.
bugs:
- https://github.com/mozilla-mobile/fenix/issues/26551
data_reviews:
- https://github.com/mozilla-mobile/fenix/pull/TODO
data_sensitivity:
- interaction
notification_emails:
- android-probes@mozilla.com
expires: 119
metadata:
tags:
- Onboarding
welcome_get_started_clicked:
type: event
description:
The user clicked the `Get started` button from the welcome onboarding
card.
bugs:
- https://github.com/mozilla-mobile/fenix/issues/26551
data_reviews:
- https://github.com/mozilla-mobile/fenix/pull/TODO
data_sensitivity:
- interaction
notification_emails:
- android-probes@mozilla.com
expires: 119
metadata:
tags:
- Onboarding
sync_card_impression:
type: event
description:
The sync sign in onboarding card was displayed to the user.
bugs:
- https://github.com/mozilla-mobile/fenix/issues/26551
data_reviews:
- https://github.com/mozilla-mobile/fenix/pull/TODO
data_sensitivity:
- interaction
notification_emails:
- android-probes@mozilla.com
expires: 119
metadata:
tags:
- Onboarding
sync_close_clicked:
type: event
description:
The user clicked the `X` button from the sync sign in onboarding card.
bugs:
- https://github.com/mozilla-mobile/fenix/issues/26551
data_reviews:
- https://github.com/mozilla-mobile/fenix/pull/TODO
data_sensitivity:
- interaction
notification_emails:
- android-probes@mozilla.com
expires: 119
metadata:
tags:
- Onboarding
sync_sign_in_clicked:
type: event
description:
The user clicked the `Sign in` button from the sync sign in
onboarding card.
bugs:
- https://github.com/mozilla-mobile/fenix/issues/26551
data_reviews:
- https://github.com/mozilla-mobile/fenix/pull/TODO
data_sensitivity:
- interaction
notification_emails:
- android-probes@mozilla.com
expires: 119
metadata:
tags:
- Onboarding
sync_skip_clicked:
type: event
description:
The user clicked the `Skip` button from the sign in onboarding card.
bugs:
- https://github.com/mozilla-mobile/fenix/issues/26551
data_reviews:
- https://github.com/mozilla-mobile/fenix/pull/TODO
data_sensitivity:
- interaction
notification_emails:
- android-probes@mozilla.com
expires: 119
metadata:
tags:
- Onboarding

search_shortcuts:
selected:
Expand Down
28 changes: 25 additions & 3 deletions app/src/main/java/org/mozilla/fenix/onboarding/view/Onboarding.kt
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,12 @@ import androidx.compose.ui.text.style.TextAlign
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import com.google.accompanist.insets.statusBarsPadding
import mozilla.telemetry.glean.private.NoExtras
import org.mozilla.fenix.R
import org.mozilla.fenix.compose.button.PrimaryButton
import org.mozilla.fenix.compose.button.SecondaryButton
import org.mozilla.fenix.theme.FirefoxTheme
import org.mozilla.fenix.GleanMetrics.Onboarding as OnboardingMetrics

/**
* Enum that represents the onboarding screen that is displayed.
Expand Down Expand Up @@ -81,7 +83,16 @@ fun Onboarding(
modifier = Modifier.fillMaxWidth(),
horizontalArrangement = Arrangement.End,
) {
IconButton(onClick = onDismiss) {
IconButton(
onClick = {
if (onboardingState == OnboardingState.Welcome) {
OnboardingMetrics.welcomeCloseClicked.record(NoExtras())
} else {
OnboardingMetrics.syncCloseClicked.record(NoExtras())
}
onDismiss()
}
) {
Icon(
painter = painterResource(id = R.drawable.mozac_ic_close),
contentDescription = null,
Expand All @@ -97,21 +108,32 @@ fun Onboarding(
onboardingState = onboardingState,
isSyncSignIn = isSyncSignIn,
onGetStartedButtonClick = {
OnboardingMetrics.welcomeGetStartedClicked.record(NoExtras())
if (isSyncSignIn) {
onDismiss()
} else {
onboardingState = OnboardingState.SyncSignIn
}
},
)

OnboardingMetrics.welcomeCardImpression.record(NoExtras())
} else if (onboardingState == OnboardingState.SyncSignIn) {
OnboardingSyncSignInContent()

OnboardingSyncSignInBottomContent(
onboardingState = onboardingState,
onSignInButtonClick = onSignInButtonClick,
onSkipButtonClick = onDismiss,
onSignInButtonClick = {
OnboardingMetrics.syncSignInClicked.record(NoExtras())
onSignInButtonClick()
},
onSkipButtonClick = {
OnboardingMetrics.syncSkipClicked.record(NoExtras())
onDismiss()
}
)

OnboardingMetrics.syncCardImpression.record(NoExtras())
}
}
}
Expand Down

0 comments on commit 8bef183

Please sign in to comment.