For #3834 - Initialize job in init

mozilla-mobile · Jul 1, 2019 · bed926c · bed926c
1 parent 50052c9
commit bed926c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 15 deletions.
diff --git a/app/src/main/java/org/mozilla/fenix/utils/AdapterWithJob.kt b/app/src/main/java/org/mozilla/fenix/utils/AdapterWithJob.kt
@@ -11,15 +11,10 @@ import kotlinx.coroutines.Job
 
 /**
  * [RecyclerView.Adapter] with a [Job] for coroutines.
- * The adapterJob is setup when the adapter is attached to a RecyclerView and canceled when detached.
+ * The adapterJob is setup when the adapter is initialized to a RecyclerView and canceled when detached.
  */
 abstract class AdapterWithJob<VH : RecyclerView.ViewHolder> : RecyclerView.Adapter<VH>() {
-    protected lateinit var adapterJob: Job
-
-    override fun onAttachedToRecyclerView(recyclerView: RecyclerView) {
-        super.onAttachedToRecyclerView(recyclerView)
-        adapterJob = Job()
-    }
+    protected var adapterJob: Job = Job()
 
     override fun onDetachedFromRecyclerView(recyclerView: RecyclerView) {
         super.onDetachedFromRecyclerView(recyclerView)
@@ -29,17 +24,12 @@ abstract class AdapterWithJob<VH : RecyclerView.ViewHolder> : RecyclerView.Adapt
 
 /**
  * [ListAdapter] with a [Job] for coroutines.
- * The adapterJob is setup when the adapter is attached to a RecyclerView and canceled when detached.
+ * The adapterJob is setup when the adapter is initialized to a RecyclerView and canceled when detached.
  */
 abstract class ListAdapterWithJob<T, VH : RecyclerView.ViewHolder>(
     diffCallback: DiffUtil.ItemCallback<T>
 ) : ListAdapter<T, VH>(diffCallback) {
-    protected lateinit var adapterJob: Job
-
-    override fun onAttachedToRecyclerView(recyclerView: RecyclerView) {
-        super.onAttachedToRecyclerView(recyclerView)
-        adapterJob = Job()
-    }
+    protected var adapterJob: Job = Job()
 
     override fun onDetachedFromRecyclerView(recyclerView: RecyclerView) {
         super.onDetachedFromRecyclerView(recyclerView)

diff --git a/app/src/main/res/navigation/nav_graph.xml b/app/src/main/res/navigation/nav_graph.xml
@@ -405,7 +405,6 @@
     <dialog
         android:id="@+id/shareFragment"
         android:name="org.mozilla.fenix.share.ShareFragment"
-        android:label="fragment_share"
         tools:layout="@layout/fragment_share" >
         <argument
             android:name="url"