Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Commit

Permalink
No issue: Renew/Remove metrics set to expire in v104
Browse files Browse the repository at this point in the history
  • Loading branch information
Amejia481 committed May 26, 2022
1 parent 67d5051 commit d1a8ec5
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 36 deletions.
44 changes: 11 additions & 33 deletions app/metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ events:
- interaction
notification_emails:
- android-probes@mozilla.com
expires: 104
expires: 116
toolbar_menu_visible:
type: event
description: |
Expand Down Expand Up @@ -2143,7 +2143,7 @@ bookmarks_management:
- interaction
notification_emails:
- android-probes@mozilla.com
expires: 104
expires: 116
metadata:
tags:
- Bookmarks
Expand Down Expand Up @@ -3638,7 +3638,7 @@ tabs_tray:
- interaction
notification_emails:
- android-probes@mozilla.com
expires: 104
expires: 116
metadata:
tags:
- Tabs
Expand All @@ -3655,7 +3655,7 @@ tabs_tray:
- interaction
notification_emails:
- android-probes@mozilla.com
expires: 104
expires: 116
metadata:
tags:
- Tabs
Expand Down Expand Up @@ -5609,7 +5609,7 @@ addons:
- interaction
notification_emails:
- android-probes@mozilla.com
expires: 104
expires: 116
metadata:
tags:
- WebExtensions
Expand All @@ -5635,29 +5635,7 @@ addons:
- interaction
notification_emails:
- android-probes@mozilla.com
expires: 104
metadata:
tags:
- WebExtensions
open_addon_setting:
type: event
description: |
A user opened an add-on's setting
extra_keys:
addon_id:
description: |
The id of the add-on that was interacted with
type: string
bugs:
- https://github.com/mozilla-mobile/fenix/issues/17644
data_reviews:
- https://github.com/mozilla-mobile/fenix/pull/18504
- https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789
data_sensitivity:
- interaction
notification_emails:
- android-probes@mozilla.com
expires: 104
expires: 116
metadata:
tags:
- WebExtensions
Expand Down Expand Up @@ -5752,7 +5730,7 @@ addons:
- interaction
notification_emails:
- android-probes@mozilla.com
expires: 104
expires: 116

metadata:
tags:
Expand Down Expand Up @@ -6414,7 +6392,7 @@ engine_tab:
notification_emails:
- android-probes@mozilla.com
- skaspari@mozilla.com
expires: 103
expires: 116
metadata:
tags:
- Performance
Expand All @@ -6435,7 +6413,7 @@ engine_tab:
notification_emails:
- android-probes@mozilla.com
- skaspari@mozilla.com
expires: 103
expires: 116
metadata:
tags:
- Performance
Expand All @@ -6456,7 +6434,7 @@ engine_tab:
notification_emails:
- android-probes@mozilla.com
- skaspari@mozilla.com
expires: 103
expires: 116
metadata:
tags:
- Performance
Expand All @@ -6476,7 +6454,7 @@ engine_tab:
notification_emails:
- android-probes@mozilla.com
- skaspari@mozilla.com
expires: 103
expires: 116
extra_keys:
background_active_tabs:
description: |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import kotlinx.coroutines.launch
import mozilla.components.feature.addons.Addon
import mozilla.components.feature.addons.AddonManagerException
import mozilla.components.feature.addons.ui.translateName
import org.mozilla.fenix.GleanMetrics.Addons
import org.mozilla.fenix.HomeActivity
import org.mozilla.fenix.R
import org.mozilla.fenix.databinding.FragmentInstalledAddOnDetailsBinding
Expand Down Expand Up @@ -212,8 +211,6 @@ class InstalledAddonDetailsFragment : Fragment() {
binding.settings.apply {
isVisible = shouldSettingsBeVisible()
setOnClickListener {
Addons.openAddonSetting.record(Addons.OpenAddonSettingExtra(addon.id))

val settingUrl = addon.installedState?.optionsPageUrl ?: return@setOnClickListener
val directions = if (addon.installedState?.openOptionsPageInTab == true) {
val components = it.context.components
Expand Down

0 comments on commit d1a8ec5

Please sign in to comment.