Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Remove dividers #10525

Closed
yoasif opened this issue May 8, 2020 · 6 comments · Fixed by #11243
Closed

[Bug] Remove dividers #10525

yoasif opened this issue May 8, 2020 · 6 comments · Fixed by #11243
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Tabs S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@yoasif
Copy link
Contributor

yoasif commented May 8, 2020

Steps to reproduce

  1. Enable tab tray
  2. Open some tabs
  3. Open tab 3rd position from top
  4. Open tab tray

Expected behavior

  1. Divider is across the width of the screen or at least centered between items (not offset to one side)
  2. The open tab highlight should be the same height across its length, not thicker on one end and thicker on the other.

Actual behavior

Divider seems to avoid tab thumbnail. Tab highlight looks weird because the height is inconsistent across its length.

ScreenshotUNITO-UNDERSCORE!2020-05-08-12-06-11!

Device information

  • Android device: Moto G
  • Fenix version: latest nightly

┆Issue is synchronized with this Jira Task

@yoasif yoasif added the 🐞 bug Crashes, Something isn't working, .. label May 8, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label May 8, 2020
@LaurentiuApahideanSV
Copy link

I can confirm that this issue is reproducible using the latest version of Firefox Preview Nightly 200512 (Build #21330603).

Devices:
Huawei MediaPad M3 lite 10 (Android 7.0)

@LaurentiuApahideanSV LaurentiuApahideanSV added S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist and removed needs:triage Issue needs triage labels May 12, 2020
@topotropic
Copy link

Thanks for the feedback – I'd suggest we remove the dividers.

@liuche
Copy link
Contributor

liuche commented Jun 2, 2020

@boek would this be a good bug for @person808? Could start working in the tabs tray team too.

@liuche liuche changed the title [Bug] Tab tray divider causes inconsistent height for tab highlight [Bug] Remove dividers Jun 4, 2020
@darkwing
Copy link
Contributor

darkwing commented Jun 4, 2020

@liuche Yes, @person808 would be an awesome choice! I think it's basically just reverting these two:

@person808 person808 self-assigned this Jun 4, 2020
@person808
Copy link
Contributor

person808 commented Jun 4, 2020

I assume point 2 doesn't apply anymore since the tab tray looks different now.

Edit: Nevermind, I misunderstood what point 2 was referring to

person808 added a commit to person808/fenix that referenced this issue Jun 4, 2020
boek pushed a commit that referenced this issue Jun 5, 2020
@person808 person808 added the eng:qa:needed QA Needed label Jun 8, 2020
@LaurentiuApahideanSV
Copy link

Verified as fixed on Firefox Preview Nightly 200606 (Build #21610607) using a Huawei MediaPad M3 (Android 7.0).

@LaurentiuApahideanSV LaurentiuApahideanSV added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 9, 2020
@liuche liuche mentioned this issue Jun 10, 2020
29 tasks
@data-sync-user data-sync-user changed the title [Bug] Remove dividers FNX-4351 ⁃ [Bug] Remove dividers Jul 30, 2020
@data-sync-user data-sync-user changed the title FNX-4351 ⁃ [Bug] Remove dividers FNX2-16001 ⁃ [Bug] Remove dividers Jul 31, 2020
@data-sync-user data-sync-user changed the title FNX2-16001 ⁃ [Bug] Remove dividers FNX-4351 ⁃ [Bug] Remove dividers Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX-4351 ⁃ [Bug] Remove dividers FNX3-13962 ⁃ [Bug] Remove dividers Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-13962 ⁃ [Bug] Remove dividers FNX-4351 ⁃ [Bug] Remove dividers Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-4351 ⁃ [Bug] Remove dividers FNX2-16001 ⁃ [Bug] Remove dividers Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16001 ⁃ [Bug] Remove dividers [Bug] Remove dividers May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Tabs S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants