This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Bug] Remove dividers #10525
Labels
🐞 bug
Crashes, Something isn't working, ..
eng:qa:verified
QA Verified
Feature:Tabs
S2
Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Comments
I can confirm that this issue is reproducible using the latest version of Firefox Preview Nightly 200512 (Build #21330603). Devices: |
LaurentiuApahideanSV
added
S2
Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
and removed
needs:triage
Issue needs triage
labels
May 12, 2020
Thanks for the feedback – I'd suggest we remove the dividers. |
@boek would this be a good bug for @person808? Could start working in the tabs tray team too. |
liuche
changed the title
[Bug] Tab tray divider causes inconsistent height for tab highlight
[Bug] Remove dividers
Jun 4, 2020
@liuche Yes, @person808 would be an awesome choice! I think it's basically just reverting these two: |
I assume point 2 doesn't apply anymore since the tab tray looks different now. Edit: Nevermind, I misunderstood what point 2 was referring to |
person808
added a commit
to person808/fenix
that referenced
this issue
Jun 4, 2020
boek
pushed a commit
that referenced
this issue
Jun 5, 2020
Verified as fixed on Firefox Preview Nightly 200606 (Build #21610607) using a Huawei MediaPad M3 (Android 7.0). |
LaurentiuApahideanSV
added
eng:qa:verified
QA Verified
and removed
eng:qa:needed
QA Needed
labels
Jun 9, 2020
4 tasks
data-sync-user
changed the title
[Bug] Remove dividers
FNX-4351 ⁃ [Bug] Remove dividers
Jul 30, 2020
data-sync-user
changed the title
FNX-4351 ⁃ [Bug] Remove dividers
FNX2-16001 ⁃ [Bug] Remove dividers
Jul 31, 2020
data-sync-user
changed the title
FNX2-16001 ⁃ [Bug] Remove dividers
FNX-4351 ⁃ [Bug] Remove dividers
Aug 10, 2020
data-sync-user
changed the title
FNX-4351 ⁃ [Bug] Remove dividers
FNX3-13962 ⁃ [Bug] Remove dividers
Aug 10, 2020
data-sync-user
changed the title
FNX3-13962 ⁃ [Bug] Remove dividers
FNX-4351 ⁃ [Bug] Remove dividers
Aug 11, 2020
data-sync-user
changed the title
FNX-4351 ⁃ [Bug] Remove dividers
FNX2-16001 ⁃ [Bug] Remove dividers
Aug 11, 2020
data-sync-user
changed the title
FNX2-16001 ⁃ [Bug] Remove dividers
[Bug] Remove dividers
May 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
🐞 bug
Crashes, Something isn't working, ..
eng:qa:verified
QA Verified
Feature:Tabs
S2
Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Steps to reproduce
Expected behavior
Actual behavior
Divider seems to avoid tab thumbnail. Tab highlight looks weird because the height is inconsistent across its length.
UNITO-UNDERSCORE!2020-05-08-12-06-11!
Device information
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: