Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[UX] Tab crash page #1102

Closed
lime124 opened this issue Mar 20, 2019 · 25 comments
Closed

[UX] Tab crash page #1102

lime124 opened this issue Mar 20, 2019 · 25 comments
Assignees
Labels
Milestone

Comments

@lime124
Copy link
Collaborator

lime124 commented Mar 20, 2019

Requirements:

  1. New copy for the description since we're saving history and not a private browser
  2. How "restoring" a session should look (likely a restore session button similar to close tab, with copy that reflects this)

There's also this question: #1003 (comment)

┆Issue is synchronized with this Jira Task

@brampitoyo brampitoyo changed the title [UX] crash reporting [UX] Tab crash page Mar 20, 2019
@brampitoyo
Copy link

Changed the issue name to reflect the fact that this error page appears only when a single tab has crashed – not when the whole app crashed.

@brampitoyo
Copy link

@sblatz Here’s a mockup for tab crashed page, along with copy that @mheubusch has written:

Inspectable mockup: https://mozilla.invisionapp.com/project/17050512

(Note that the illustration is still a placeholder, but the measurements are correct).

@sblatz
Copy link
Contributor

sblatz commented Mar 21, 2019

@brampitoyo is <name> here the name of the user? If so, how will we know their name if they don't have an account?

(perhaps it's just "Fenix" in this case?)

@mheubusch
Copy link
Contributor

mheubusch commented Mar 21, 2019 via email

@sblatz
Copy link
Contributor

sblatz commented Mar 21, 2019

Thanks for the clarification, I also don't seem to have access to that placeholder image (even when I do inspect mode, there's no asset), are you able to send it to me? :)

@mheubusch
Copy link
Contributor

@sblatz did you get the asset you needed for restore tab? Also do you need a new user story/epic for restore session?

@lime124
Copy link
Collaborator Author

lime124 commented Mar 23, 2019

@mheubusch sean got him all the error page illustrations and strings on friday.

@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Mar 27, 2019

@mheubusch Hello, it might be just me, but the crash message sounds like the tab can't be restored, although there's still a "restore tab" option.

#2: There's no "send crash report" option in the tab crash reporter. Is that intentional?

@mheubusch
Copy link
Contributor

@sv-ohorvath not just you. :) Have someone on my team taking a fresh look at this - thank you. also, IICR we are handling crash reporting options in the settings, not at the page level but @brampitoyo can confirm.

@MeridelW
Copy link

Hi @sv-ohorvath! That copy has indeed been updated (see attachment for latest mock—still a work in progress...for example, button copy should be all caps). The user can indeed "try again" and the copy no longer contradicts this.

As for "send crash report," there is a separate prompt that comes up in the flow for the user to report an issue. This is the only error that has the reporting function as this is the only error that is Mozilla's fault.
New content crash message

@sblatz
Copy link
Contributor

sblatz commented Mar 27, 2019

This page is currently being displayed when a tab crashes. GV team is working on a feature that would allow a tab to be restored after it has crashed, but right now we can only close it (or choose to reload the page without any history). I don't think a "try again" button being the only option is good, as it does not give a clear indication to the user that they may be forced to just close the tab to get out of the loop.

Do we want to change the behavior of "restore tab" to just reload the URL of the crashed tab with no history?

@MeridelW
Copy link

@brampitoyo Can you weigh in on this? What's the best way to give the user the option to close the tab? I agree we need this.

@sblatz What are the implications of reloading with no history?

@sblatz
Copy link
Contributor

sblatz commented Mar 27, 2019

@MeridelW Essentially it would be like they had just started a brand new tab with that page loaded. This means their scroll position, any data entered, any previous history of browsing on that tab would be lost.

@MeridelW
Copy link

@brampitoyo What are your thoughts on this?

@brampitoyo
Copy link

@sblatz @MeridelW In earlier mockup, we have options for “Close tab” and “Restore tab”. Shall we use those?

“Restore tab” would make sense only if we can ensure that the tab won’t crash again (and go into a reload-crash-error-reload-crash-error… loop). Otherwise, “Close tab” is a safer bet.

Would starting a brand new tab without saving anything help fix this loop?

@sblatz
Copy link
Contributor

sblatz commented Mar 27, 2019

@brampitoyo "Restore tab" could attempt to restore once, then would send us back to the same spot, but the user could then press "close tab". Keep in mind that this option is not yet available on the GeckoView side, so we could have "restore tab" just reload the tab's URL with no history, which, if it crashed again, would leave the user in a position to press "close tab" if they think they're in a loop.

@brampitoyo
Copy link

@sblatz OK. Let’s go with “Close tab” and “Restore tab”, then. This way, the user can try to recover (which is always a preferred option), and can close when recovery fails.

@brampitoyo
Copy link

@sblatz Please find the new tab crash design (the only change is the inclusion of two buttons: close and restore) here: https://mozilla.invisionapp.com/share/P7R8W1ZWHM6

@sblatz
Copy link
Contributor

sblatz commented Mar 28, 2019

@brampitoyo After some more work on this, it seems we actually don't have the ability to reload the tab just yet. I will just use a "close tab" button for now, and will add the "reload tab" when this functionality is added by the GV team

@brampitoyo
Copy link

Paging @shorlander to review the design above.

@shorlander
Copy link

shorlander commented Apr 18, 2019

Looks good to me.

@brampitoyo I don't know if we have illustrations in these pages yet, but Sean says we should use fx-fenix_error_9.svg for this.

@mheubusch
Copy link
Contributor

@sblatz just a reminder that the actual string is Sorry. can't load that page.

@brampitoyo
Copy link

@shorlander Thanks! Below is the updated mockup containing the latest illustration from Sean:

@vesta0 vesta0 modified the milestones: MVP Backlog, UX Backlog May 16, 2019
@vesta0 vesta0 removed UX labels Jun 26, 2019
@vesta0
Copy link
Collaborator

vesta0 commented Jul 3, 2019

@mheubusch I believe this can be closed?

@data-sync-user data-sync-user changed the title [UX] Tab crash page FNX2-16289 ⁃ [UX] Tab crash page Jul 31, 2020
@data-sync-user data-sync-user changed the title FNX2-16289 ⁃ [UX] Tab crash page FNX3-14331 ⁃ [UX] Tab crash page Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-14331 ⁃ [UX] Tab crash page FNX-4799 ⁃ [UX] Tab crash page Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-4799 ⁃ [UX] Tab crash page FNX2-16289 ⁃ [UX] Tab crash page Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16289 ⁃ [UX] Tab crash page [UX] Tab crash page May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

10 participants