Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] The Fenix Share Sheet is missing several items #11177

Closed
ghost opened this issue Jun 3, 2020 · 6 comments
Closed

[Bug] The Fenix Share Sheet is missing several items #11177

ghost opened this issue Jun 3, 2020 · 6 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Sharing

Comments

@ghost
Copy link

ghost commented Jun 3, 2020

Steps to reproduce

The Fenix Share Sheet is missing several apps that can be shared to: Add to Pocket, WhatsApp, Discord, Wikipedia search, Mega, Twitter's Direct Message, RAR etc...

But the 77.0.0-beta.1 contains all share shortcuts

Expected behavior

The share sheet should contain all items/apps that can be shared to

Actual behavior

The Share Sheet doesn't contain all app share targets

Device information

  • Android device: Motorola One Power, Android 10
  • Fenix version: Nightly 200603 06:00

┆Issue is synchronized with this Jira Task

@ghost ghost added the 🐞 bug Crashes, Something isn't working, .. label Jun 3, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 3, 2020
@cadeyrn
Copy link
Contributor

cadeyrn commented Jun 3, 2020

Pocket and Twitter Direct Message are available on my device. But I can confirm that WhatsApp and a few others are missing in Fenix but not in Firefox Beta.

@ghost ghost mentioned this issue Jun 6, 2020
@kglazko kglazko removed the needs:triage Issue needs triage label Jun 8, 2020
@neekless
Copy link
Contributor

neekless commented Jun 9, 2020

Mine has WhatsApp as an available share target. What's interesting is I no longer have Telegram X as an available target, which is strange because I've used sharing to Telegram X plenty of times in past versions. I'm not sure from which version did I start losing Telegram X share target. Could it be that Fenix has a fixed limit on number of share targets thus some would not be shown?
Screenshot_20200610-011704

@ghost
Copy link
Author

ghost commented Jun 9, 2020

@neekless I don't think developers have done this intentionally. Since it is really important that all share targets are presented in the share sheet otherwise how do you expect to share/open in app the links if the particular app is not there? I cannot even share links to copy them!

@ekager ekager added the eng:ready Ready for engineering label Jun 9, 2020
@Mugurell Mugurell self-assigned this Jun 10, 2020
Mugurell added a commit that referenced this issue Jun 11, 2020
This was previously regressed by having the RecyclerViews for "recent" and
"all" items put inside a HorizontalScrollView which would then prevent the
RecyclerViews from actually scrolling, recycling, showing new items.

As a quick solution that would keep the desired behavior the "all" items list
is now a child of a RelativeLayout which will allow it to load all items at
once and so all the share targets will be available to the user but which also
means no recycling.

The RecyclerView for the "recent" items uses a `RECENT_APPS_LIMIT = 6` so this
does not need the same "fix" as all the items would fit the screen without
any issue.
@buz-ch
Copy link

buz-ch commented Jun 12, 2020

That seems to have fixed it for me after installing today's build.

Thanks a lot!

@ghost
Copy link
Author

ghost commented Jun 12, 2020

This is fixed for me as well.

Tested on: Motorola One Power, Android 10.
Fenix: Nightly 200612 18:01.

@abodea
Copy link
Member

abodea commented Jun 15, 2020

Verified as fixed on the latest Nightly 6/15 with Google Pixel 4 XL (10).

@abodea abodea closed this as completed Jun 15, 2020
@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 15, 2020
@data-sync-user data-sync-user changed the title [Bug] The Fenix Share Sheet is missing several items FNX2-16375 ⁃ [Bug] The Fenix Share Sheet is missing several items Jul 31, 2020
@data-sync-user data-sync-user changed the title FNX2-16375 ⁃ [Bug] The Fenix Share Sheet is missing several items FNX3-14445 ⁃ [Bug] The Fenix Share Sheet is missing several items Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-14445 ⁃ [Bug] The Fenix Share Sheet is missing several items FNX-12054 ⁃ [Bug] The Fenix Share Sheet is missing several items Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12054 ⁃ [Bug] The Fenix Share Sheet is missing several items FNX2-16375 ⁃ [Bug] The Fenix Share Sheet is missing several items Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16375 ⁃ [Bug] The Fenix Share Sheet is missing several items [Bug] The Fenix Share Sheet is missing several items May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Sharing
Projects
None yet
Development

No branches or pull requests

9 participants