Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Synced Tabs Crash RemoteTabProviderException #11294

Closed
1 task done
ekager opened this issue Jun 6, 2020 · 8 comments · Fixed by mozilla-mobile/android-components#7560
Closed
1 task done

[Bug] Synced Tabs Crash RemoteTabProviderException #11294

ekager opened this issue Jun 6, 2020 · 8 comments · Fixed by mozilla-mobile/android-components#7560
Labels
a-s Application Services work needed b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info 🐞 bug Crashes, Something isn't working, .. eng:ready Ready for engineering Feature:Sync

Comments

@ekager
Copy link
Contributor

ekager commented Jun 6, 2020

RemoteTabProviderException

Protobuf decode error: failed to decode Protobuf message: unexpected end group tag

mozilla.appservices.remotetabs.RemoteTabProviderException: Protobuf decode error: failed to decode Protobuf message: unexpected end group tag
at mozilla.appservices.remotetabs.rust.RustError.intoException(RustError.kt:4)
at mozilla.appservices.remotetabs.RemoteTabsProvider.setLocalTabs(RemoteTabsProvider.kt:14)
at mozilla.components.browser.storage.sync.RemoteTabsStorage$store$2.invokeSuspend(RemoteTabsStorage.kt:16)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:3)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:21)
at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:1)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:11)

https://sentry.prod.mozaws.net/operations/fenix-fennec-nightly/issues/8617877/?query=RemoteTabProviderException

┆Issue is synchronized with this Jira Task

@ekager ekager added 🐞 bug Crashes, Something isn't working, .. b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info Feature:Sync a-s Application Services work needed labels Jun 6, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 6, 2020
@ekager ekager removed the needs:triage Issue needs triage label Jun 6, 2020
@liuche
Copy link
Contributor

liuche commented Jun 8, 2020

@eoger 👀

@ekager
Copy link
Contributor Author

ekager commented Jun 9, 2020

jira issue is https://jira.mozilla.com/browse/SYNC-1382

@liuche
Copy link
Contributor

liuche commented Jun 10, 2020

Synced Tabs is something that Vesta really wants for release (though I'd say it's lower priority than overwriting engine sync preferences: mozilla-mobile/android-components#7233) cc @jdragojevic

@thomcc
Copy link

thomcc commented Jun 17, 2020

We believe v61.0.3 has a fix for this https://github.com/mozilla/application-services/releases/tag/v61.0.3. We're preparing a workaround if that proves not to be the actual issue, which is possible since we were only able to mostly repro the issue in question.

@liuche liuche mentioned this issue Jun 22, 2020
3 tasks
@liuche
Copy link
Contributor

liuche commented Jun 24, 2020

There's an AC PR to bump AS to 61.0.4, and once that lands, we should remove this feature flag. (And if this doesn't work out, we can re-flag it)

@liuche liuche added the eng:ready Ready for engineering label Jun 25, 2020
@ekager
Copy link
Contributor Author

ekager commented Jun 25, 2020

We're now on 61.0.6 we should keep an eye on Sentry for a day or two to see if these crashes go down.

@thomcc
Copy link

thomcc commented Jun 26, 2020

This looks like it's still had a couple errors come in under 61.0.6 :(

I'll reopen the issue on the a-s side and prepare a patch switching from protobufs to JSON, which shouldn't have this sort of issue.

@kbrosnan
Copy link
Contributor

kbrosnan commented Jul 2, 2020

@data-sync-user data-sync-user changed the title [Bug] Synced Tabs Crash RemoteTabProviderException FNX3-14526 ⁃ [Bug] Synced Tabs Crash RemoteTabProviderException Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-14526 ⁃ [Bug] Synced Tabs Crash RemoteTabProviderException FNX-12202 ⁃ [Bug] Synced Tabs Crash RemoteTabProviderException Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12202 ⁃ [Bug] Synced Tabs Crash RemoteTabProviderException FNX2-13412 ⁃ [Bug] Synced Tabs Crash RemoteTabProviderException Aug 11, 2020
@kbrosnan kbrosnan changed the title FNX2-13412 ⁃ [Bug] Synced Tabs Crash RemoteTabProviderException [Bug] Synced Tabs Crash RemoteTabProviderException Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a-s Application Services work needed b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info 🐞 bug Crashes, Something isn't working, .. eng:ready Ready for engineering Feature:Sync
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants