Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Undo close tab in tabs tray unexpectedly restores tab to top, offscreen #11431

Closed
mcomella opened this issue Jun 10, 2020 · 6 comments
Closed
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Tabs needs:ac Needs Android Component Work

Comments

@mcomella
Copy link
Contributor

mcomella commented Jun 10, 2020

Steps to reproduce

  • Open enough tabs so the tabs tray can scroll
  • Scroll to the bottom
  • Press X to close tab
  • Press Undo on snack bar

Expected behavior

Tab restores in same location it was in before.

Actual behavior

Tab restores at top, off-screen

Video of behavior: https://drive.google.com/file/d/1N2d8tUSJZeOZgMiWR49iYeS9gjapKFro/view?usp=sharing

Device information

  • Android device: P2
  • Fenix version: Nightly 200610

┆Issue is synchronized with this Jira Task

@mcomella mcomella added the 🐞 bug Crashes, Something isn't working, .. label Jun 10, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 10, 2020
@yoasif
Copy link
Contributor

yoasif commented Jun 10, 2020

Your title is better than mine, but this is a dupe of #11236

@gabrielluong gabrielluong added Skittle Feature:Tabs and removed needs:triage Issue needs triage labels Jun 10, 2020
@ekager
Copy link
Contributor

ekager commented Jun 10, 2020

on restore we could scroll to the top of the list because we know that the restored tab will be there. Does that make sense @topotropic ?

@topotropic
Copy link

on restore we could scroll to the top of the list because we know that the restored tab will be there. Does that make sense @topotropic ?

yes, thanks! If it's possible to add the tab to the position in the list where it was, that would be even better.

@yoasif
Copy link
Contributor

yoasif commented Jun 17, 2020

If it's possible to add the tab to the position in the list where it was, that would be even better.

I think this is what ought to happen. In the situation where the user does:

  1. Closes tab
  2. scrolls tab list far away from current tab
  3. restores tab

We should restore to same position it was prior and scroll tab into view.

@ekager
Copy link
Contributor

ekager commented Jul 10, 2020

Part 1 of this is done. We now scroll to a restored tab, so let's QA that.

Opened #12449 for restoring the tab to its previous position

@ekager ekager added the eng:qa:needed QA Needed label Jul 10, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jul 13, 2020

Hi, verified as fixed on Firefox Nightly Build 200711 from 7/11 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

► Video
20200713-100343

@AndiAJ AndiAJ closed this as completed Jul 13, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jul 13, 2020
@data-sync-user data-sync-user changed the title [Bug] Undo close tab in tabs tray unexpectedly restores tab to top, offscreen FNX-12365 ⁃ [Bug] Undo close tab in tabs tray unexpectedly restores tab to top, offscreen Aug 1, 2020
@data-sync-user data-sync-user changed the title FNX-12365 ⁃ [Bug] Undo close tab in tabs tray unexpectedly restores tab to top, offscreen FNX3-14633 ⁃ [Bug] Undo close tab in tabs tray unexpectedly restores tab to top, offscreen Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-14633 ⁃ [Bug] Undo close tab in tabs tray unexpectedly restores tab to top, offscreen FNX-12365 ⁃ [Bug] Undo close tab in tabs tray unexpectedly restores tab to top, offscreen Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12365 ⁃ [Bug] Undo close tab in tabs tray unexpectedly restores tab to top, offscreen FNX2-13463 ⁃ [Bug] Undo close tab in tabs tray unexpectedly restores tab to top, offscreen Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-13463 ⁃ [Bug] Undo close tab in tabs tray unexpectedly restores tab to top, offscreen [Bug] Undo close tab in tabs tray unexpectedly restores tab to top, offscreen May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Tabs needs:ac Needs Android Component Work
Projects
None yet
Development

No branches or pull requests

9 participants