Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Telemetry] Download events #11578

Closed
7 tasks
vesta0 opened this issue Jun 15, 2020 · 9 comments
Closed
7 tasks

[Telemetry] Download events #11578

vesta0 opened this issue Jun 15, 2020 · 9 comments
Assignees
Labels
eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Download Feature:Telemetry P2 Upcoming release

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Jun 15, 2020

Description & Product Manager / Data Scientist User Story

As a product manager, I need to know how often something is downloaded using the browser, so I can appropriately prioritize enhancing the download experience in relation to other features.

What questions will you answer with this data?

-What percentage of total and weekly active users download a file using the browser? (e.g. 7% of total users and 5% of weekly active users download a file)

-How often do users download a file? (e.g. 3 % of users download a file every day, 2% of users download 3 files a week.)

Note: we track the interactions with download notifications but I don't believe we track the actual download events.

Acceptance Criteria

  • ENG files a DS JIRA request outlining their methodology.
  • DS sign off on instrumentation methodology addressing product questions.
  • Event pings can be queried via re:dash
  • Event pings can be queried via amplitude
  • We are sending telemetry events for the actions listed in the requirements
  • We have documented the telemetry
  • We have asked a data steward to review the telemetry

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 15, 2020
@vesta0 vesta0 removed the needs:triage Issue needs triage label Jun 15, 2020
@sblatz
Copy link
Contributor

sblatz commented Jun 15, 2020

@vesta0

"Note: we track the interactions with download notifications but I don't believe we track the actual download events."

Are these meaningfully different? notifications will always appear for users when a download begins, finishes, or fails.

@sblatz
Copy link
Contributor

sblatz commented Jun 15, 2020

Ah! One case where they're different:

Long press image -> contextual menu -> save image. Triggers a download but does NOT trigger a "download notification" until it's saved.

@sblatz
Copy link
Contributor

sblatz commented Jun 15, 2020

So we should add events firing for downloads.

@liuche
Copy link
Contributor

liuche commented Jun 30, 2020

Eng needs to file the DS Jira bug for this.

@eliserichards
Copy link

This has been approved by Marissa during our all hands Telemetry Jam, so we don't need to file a ticket for this.

@eliserichards eliserichards added the eng:ready Ready for engineering label Aug 3, 2020
@data-sync-user data-sync-user changed the title [Telemetry] Download count FNX3-14741 ⁃ [Telemetry] Download count Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-14741 ⁃ [Telemetry] Download count FNX2-13525 ⁃ [Telemetry] Download count Aug 11, 2020
@kbrosnan kbrosnan changed the title FNX2-13525 ⁃ [Telemetry] Download count [Telemetry] Download count Aug 29, 2020
@Mugurell Mugurell self-assigned this Nov 24, 2020
@Mugurell Mugurell added the eng:qa:needed QA Needed label Dec 15, 2020
@Mugurell Mugurell changed the title [Telemetry] Download count [Telemetry] Download events Dec 16, 2020
@Mugurell
Copy link
Contributor

Mugurell commented Dec 16, 2020

Talked offline with Kate who confirmed with DS and Boek:

  • The newly added metrics should log events, not counters anymore
  • An expiration date 6 months is preferred.
    Maybe if there is already related telemetry for that part of the screen / feature we can reuse the existing expiration date so that all related telemetry probes will be renewed at the same time.

@AndiAJ
Copy link
Collaborator

AndiAJ commented Dec 16, 2020

Hi, I've just checked this matter on the latest Nightly 201216 using a Google Pixel 3a (Android 11) and it seems that the download_added event type ping is generated.

@Mugurell please review

@AndiAJ AndiAJ removed the eng:qa:needed QA Needed label Dec 16, 2020
mcarare pushed a commit that referenced this issue Dec 16, 2020
These pings were implemented first as counters.
When changing to events "send_in_pings: - metrics" still remained causing
confusion.
This patch comes to remove this confusion and potential future issues.
@Mugurell
Copy link
Contributor

Thank you @AndiAJ.
The changes should now be available to test in the current Nightly.

@Mugurell Mugurell added the eng:qa:needed QA Needed label Dec 17, 2020
@lobontiumira
Copy link

Verified as fixed on the latest Nightly build from 12/18 with Google Pixel (Android 10):

 {
          "category": "downloads_misc",
          "name": "download_added",
          "timestamp": 3279
        }

Logcat
Glean dashboard

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Dec 18, 2020
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Download Feature:Telemetry P2 Upcoming release
Projects
None yet
Development

No branches or pull requests

7 participants