Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Google is not in the "Default search engine" list #12081

Closed
ebalazs-sv opened this issue Jun 29, 2020 · 8 comments
Closed

[Bug] Google is not in the "Default search engine" list #12081

ebalazs-sv opened this issue Jun 29, 2020 · 8 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:Search Release Blocker Blocks a Release S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@ebalazs-sv
Copy link

ebalazs-sv commented Jun 29, 2020

Steps to reproduce

  1. Launch Fenix;
  2. Go to Settings -> Search;
  3. Observe the "Default search engine" list;
    1. Expected behavior
      An alphabetically ordered radio button list of search engines installed by default is displayed:
  • Google (by default)
  • Amazon.com
  • Bing
  • DuckDuckGo
  • Twitter
  • Wikipedia
    1. Actual behavior
      Google is not in the "Default search engine" list. Google is displayed now in the "Add search engine" list.
    2. Notes
      20200629UNITO-UNDERSCORE!143100!

Device information

  • Android device: Motorola Moto G6 (Android 8).
  • Fenix version: Fenix Beta 78.0.1-beta.1 GV 78 from 6/27

┆Issue is synchronized with this Jira Task

@ebalazs-sv ebalazs-sv added 🐞 bug Crashes, Something isn't working, .. Feature:Search labels Jun 29, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 29, 2020
@ebalazs-sv ebalazs-sv added S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist and removed needs:triage Issue needs triage labels Jun 29, 2020
@st3fan
Copy link
Contributor

st3fan commented Jun 29, 2020

In which locale settings was this tested? (and was there locale-switching, specific timing?)

Was this tested on a clean install?

@ebalazs-sv
Copy link
Author

The above details from the description, are for English - US locale setting, without locale-switching, on a clean-install.

I had tested this issue further and the results are:

Clean install:

  • reproducible on English - US, Espanol;
  • not reproducible on English - UK, Francais, Deutsch, Russian, Turkce, Italian;

Switching locale:

  • reproducible on English - US, Espanol, Italian;
  • not reproducible on English - UK, Francais, Deutsch, Russian, Turkce;

After Migration:

  • reproducible on English - US, Espanol;
  • not reproducible on English - UK, Francais, Deutsch, Russian, Turkce, Italian.

For the reproducible locale settings, on clean install or after clearing data, the default search engine icon, displayed on the onboarding screen is Google and after dismissing the onboarding screen, is Amazon, see #11875.

Fenix version:

  • Nightly Build 200629 from 6/29;
  • Fenix 78.0.1-beta.1 from 6/27.

Android device:

  • Google Pixel 3a (Android 10);
  • OnePlus A3 (Android 6.0.1);
  • Motorola Moto G6 (Android 8);

@Mugurell Mugurell self-assigned this Jun 30, 2020
@Mugurell Mugurell added the E3 Estimation Point: average, 2 - 3 days label Jun 30, 2020
@st3fan
Copy link
Contributor

st3fan commented Jun 30, 2020

@boek @rocketsroger can you two talk about this one? I think Roger mentioned that this may be a regression from a performance improvement ... keep it in the bug in case @Mugurell is already doing work on this please.

@boek
Copy link
Contributor

boek commented Jun 30, 2020

@st3fan already on it :)

I'll write up what I know so far after lunch

boek added a commit to boek/fenix that referenced this issue Jun 30, 2020
@boek
Copy link
Contributor

boek commented Jun 30, 2020

@st3fan @Mugurell we got a PR open, here is the fix :)

#12138

@liuche
Copy link
Contributor

liuche commented Jun 30, 2020

should be landed on both the 79 branch and nightly.

@sflorean
Copy link
Contributor

sflorean commented Jul 1, 2020

Verified as fixed on Beta build 79.0.0-beta.3 with the following devices:

  • Motorola Moto G6 (Android 8);
  • Huawei MediaPad M3 lite (Android 7);
  • Huawei P20 lite (Android 9);
  • Samsung Galaxy Tab S6 (Android 9);
  • Xiaomi Mi Pad 2 (Android 5.1);
  • OnePlus A3 (Android 6.0.1).

Google is now displayed in the search engines list, however, we were able to reproduce #11875 ->Amazon icon displayed on startup.

@data-sync-user data-sync-user changed the title [Bug] Google is not in the "Default search engine" list FNX3-15118 ⁃ [Bug] Google is not in the "Default search engine" list Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15118 ⁃ [Bug] Google is not in the "Default search engine" list FNX-13099 ⁃ [Bug] Google is not in the "Default search engine" list Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-13099 ⁃ [Bug] Google is not in the "Default search engine" list FNX2-13008 ⁃ [Bug] Google is not in the "Default search engine" list Aug 11, 2020
@Mugurell
Copy link
Contributor

Closing this as per #12081 (comment)

@data-sync-user data-sync-user changed the title FNX2-13008 ⁃ [Bug] Google is not in the "Default search engine" list [Bug] Google is not in the "Default search engine" list May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:Search Release Blocker Blocks a Release S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Development

No branches or pull requests

7 participants