Tab tray screenshots flicker when loaded in

[yoasif]

Steps to reproduce

1. Tap tab switcher icon

Expected behavior

Screenshots should be present on initial display.

Actual behavior

I see placeholders briefly, then a flicker as the screenshots are loaded. Worse still, the screenshots are not present if I open the tray a few times in succession.

See video:

Device information

• Android device: Moto G (XT1031)
• Fenix version: latest nightly

┆Issue is synchronized with this Jira Task

[liuche]

Do you know @jonalmeida if there's something that happens with the AC thumbnails loading (are we reloading them every time) or if there's something else we could do on the Fenix side re: flicker?

[jonalmeida]

@liuche If by "flicker" you mean fade in, then yes this is the default loading animation behaviour of the RecyclerView. If we want to change this, we can look into non-default state to show when the thumbnail is loading from disk or some other technique to not show the empty thumbnail state. For Fennec, I can see it's just a blank white square and the image loads without an animation.

Otherwise, I don't see any flicker in the gif above. @yoasif could you clarify?

Worse still, the screenshots are not present if I open the tray a few times in succession.

This sounds like a separate bug that I'm more interested in knowing the STR for, although it sounds like a race.

[yoasif]

@jonalmeida If I switch windows in macOS or Windows, I never see a generic "window" icon - I just see the windows when switching between them. Fennec also manages to show screenshots every time i load up its tab view without ever loading in a placeholder. That is the flicker I am referring to.

If Fennec shows white at any point, I am not seeing it, so it may be caching it (which is what I would have expected on subsequent loads of the tab tray in Fenix).

[stale]

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[jonalmeida]

With #19809, this bug is noticeable so let's see if there's anything we can do about it with the new implementation of the tabs tray.

[boek]

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1812912

Change performed by the Move to Bugzilla add-on.