Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Change default tabs tray layout to grid view #19809

Closed
jonalmeida opened this issue Jun 4, 2021 · 6 comments
Closed

Change default tabs tray layout to grid view #19809

jonalmeida opened this issue Jun 4, 2021 · 6 comments
Assignees
Labels
E1 Estimation Point: trivial, less than half day eng:qa:verified QA Verified feature request 🌟 New functionality and improvements Feature:Tabs
Milestone

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Jun 4, 2021

User Story

As a user, I want to view my tabs in the grid view thumbnail) format so it's easier for me to quickly locate the specific tab I want to get back to.

Acceptance Criteria

  • My default tabs setting is GRID view.
  • Disable the existing "grid view" CFR
  • When I open the tabs tray for the first time after updating the app, I see a message telling me that the default setting has changed. (To ENG: you can exclude this criteria for now when sizing this ticket, it's not required for iteration 1)

Linked JIRA: FNX-22614

┆Issue is synchronized with this Jira Task

@jonalmeida jonalmeida added feature request 🌟 New functionality and improvements E1 Estimation Point: trivial, less than half day labels Jun 4, 2021
@jonalmeida
Copy link
Contributor Author

I sized this as 1 because this is just a matter of changing the default pref in our settings and removing the CFR code (which exists in TabsTrayInfoBannerBinding).

@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 4, 2021
@jonalmeida jonalmeida added Feature:Tabs and removed needs:triage Issue needs triage labels Jun 4, 2021
@jonalmeida jonalmeida self-assigned this Jun 4, 2021
@gabrielluong gabrielluong added this to the 91 milestone Jun 4, 2021
@cadeyrn
Copy link
Contributor

cadeyrn commented Jun 4, 2021

@jonalmeida

Locate tabs easier

In my opinion it's MUCH easier to locate the tabs with the current list view. If you want to change the default, it's fine, I can change it back. But I don't agree that it will help to reach this specific goal.

With the grid view:

  • … I get larger thumbnails but the bigger size doesn't add any value because I can see exactly the same
  • … I can see less tabs at once
  • … the title of every tab is much shorter and useless in some cases
  • … the URL of every tab is completely missing

So how exactly is the grid view supposed to help to locate my tabs easier? For me it's pretty obvious that the grid view makes it harder to locate the tabs I am looking for. Or do you plan bigger changes of the grid view? 🧐

@jonalmeida
Copy link
Contributor Author

jonalmeida commented Jun 4, 2021

Thanks for discussing @cadeyrn !

Locate tabs easier

I think the title is just misleading, I'll update that to be more accurate of what the intention is.

Or do you plan bigger changes of the grid view? 🧐

Yes, we're looking into ways to make it easier to find tabs. That's still some on-going research. This is step 1.

… I get larger thumbnails but the bigger size doesn't add any value because I can see exactly the same

Based on telemetry and experimentation data, it showed that more people preferred grid view as the default across all channels (nightly/beta/release). From what I understand, the bigger thumbnail to identify a tab but that's just my personal guess.

… I can see less tabs at once
… the title of every tab is much shorter and useless in some cases
… the URL of every tab is completely missing

This is a good point, we should definitely re-evaluate if we make the grid layout smaller so that we can see more. We had taken some original designs based on Fennec because folks like that UI a lot and allowed us to get the feature out quicker, but we can iterate on this faster now in Fenix ⚡ .

I personally like the list layout as well, but it seems like the majority preference is grid. 🙂

FYI: this will not change your existing preference, this is just the default for new users.

@jonalmeida jonalmeida added the eng:qa:needed QA Needed label Jun 4, 2021
@jonalmeida jonalmeida changed the title Locate tabs easier (a.k.a change default to GRID view) Change default tabs tray layout to grid view Jun 4, 2021
@kythyria
Copy link

kythyria commented Jun 9, 2021

… I can see less tabs at once

In portrait, certainly. In landscape I see more tabs at once with grid view instead of less: three rather than one (but have to scroll further, and grid view is just generally awkward in landscape anyway).

@cadeyrn
Copy link
Contributor

cadeyrn commented Jun 9, 2021

In portrait, certainly. In landscape I see more tabs at once with grid view instead of less

You can assume that most people use their smartphone, especially when browsing in the web, in portrait mode. And since it's about the default layout I was arguing about the default usage. I didn't say that the grid view does not have advantages. 😉

@lobontiumira
Copy link

Verified as fixed on the latest Nightly build from 6/10 with Google Pixel (Android 10), Samsung Galaxy Tab A6 (Android 5.1.1), and HTC 10 (Android 8).

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 10, 2021
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Jun 11, 2021
This differs from `tab_view_setting` which tells us what the user's tab
setting is at startup. It does not tell us if the user explicitly
changed it instead of just using the default (which was recently
changed in mozilla-mobile#19809).
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Jun 11, 2021
This differs from `tab_view_setting` which tells us what the user's tab
setting is at startup. It does not tell us if the user explicitly
changed it instead of just using the default (which was recently
changed in mozilla-mobile#19809).
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Jul 9, 2021
This differs from `tab_view_setting` which tells us what the user's tab
setting is at startup. It does not tell us if the user explicitly
changed it instead of just using the default (which was recently
changed in mozilla-mobile#19809).
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Jul 12, 2021
This differs from `tab_view_setting` which tells us what the user's tab
setting is at startup. It does not tell us if the user explicitly
changed it instead of just using the default (which was recently
changed in mozilla-mobile#19809).
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Aug 6, 2021
This differs from `tab_view_setting` which tells us what the user's tab
setting is at startup. It does not tell us if the user explicitly
changed it instead of just using the default (which was recently
changed in mozilla-mobile#19809).
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Aug 6, 2021
This differs from `tab_view_setting` which tells us what the user's tab
setting is at startup. It does not tell us if the user explicitly
changed it instead of just using the default (which was recently
changed in mozilla-mobile#19809).
jonalmeida added a commit to jonalmeida/fenix that referenced this issue Aug 6, 2021
This differs from `tab_view_setting` which tells us what the user's tab
setting is at startup. It does not tell us if the user explicitly
changed it instead of just using the default (which was recently
changed in mozilla-mobile#19809).
mergify bot pushed a commit that referenced this issue Aug 6, 2021
This differs from `tab_view_setting` which tells us what the user's tab
setting is at startup. It does not tell us if the user explicitly
changed it instead of just using the default (which was recently
changed in #19809).
czlucius pushed a commit to czlucius/fenix that referenced this issue Aug 20, 2021
This differs from `tab_view_setting` which tells us what the user's tab
setting is at startup. It does not tell us if the user explicitly
changed it instead of just using the default (which was recently
changed in mozilla-mobile#19809).
czlucius pushed a commit to czlucius/fenix that referenced this issue Aug 22, 2021
This differs from `tab_view_setting` which tells us what the user's tab
setting is at startup. It does not tell us if the user explicitly
changed it instead of just using the default (which was recently
changed in mozilla-mobile#19809).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E1 Estimation Point: trivial, less than half day eng:qa:verified QA Verified feature request 🌟 New functionality and improvements Feature:Tabs
Projects
None yet
Development

No branches or pull requests

5 participants