Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Audio playing in background is distorted after a little bit #1461

Closed
agi90 opened this issue Apr 8, 2019 · 11 comments
Closed

[Bug] Audio playing in background is distorted after a little bit #1461

agi90 opened this issue Apr 8, 2019 · 11 comments
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Media P1 Current sprint

Comments

@agi90
Copy link
Contributor

agi90 commented Apr 8, 2019

Steps to reproduce

  • Play some audio in the browser (e.g. a song from soundcloud.com)
  • Background the browser, open another app
  • Wait for a minute or so

Expected behavior

  • Audio continues playing without issues or audio stops immediately

Actual behavior

  • Audio starts popping, probably because geckoview is not scheduled enough to maintain audio playing

Note: you might encounter https://bugzilla.mozilla.org/show_bug.cgi?id=1506957 while reproducing this.

Device information

  • Android device: Samsung S10e
  • Fenix version: 1.0.1915 (latest from playstore)

┆Issue is synchronized with this Jira Task

@agi90 agi90 added the 🐞 bug Crashes, Something isn't working, .. label Apr 8, 2019
@agi90
Copy link
Contributor Author

agi90 commented Apr 8, 2019

I think we need to notify Android that we're playing audio on the background with a notification similarly to what Fennec and other music players do.

@vesta0 vesta0 added the needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org label Apr 9, 2019
@vesta0 vesta0 added this to the Post-MVP Backlog milestone Apr 9, 2019
@dbolter
Copy link

dbolter commented May 3, 2019

@vesta0 I think we should remove "Needs GV work" per bugzilla comments?

@vesta0 vesta0 removed the needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org label May 6, 2019
@vesta0 vesta0 modified the milestones: Post-MVP Backlog, Bugs Jul 2, 2019
@vesta0 vesta0 added P2 Upcoming release needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org 🙅 waiting Issues that are blocked or has dependencies that are not ready and removed needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Jul 3, 2019
@boek boek removed this from the Bugs and Polish milestone Jul 17, 2019
@vesta0 vesta0 removed this from the Bugs and Polish milestone Jul 24, 2019
@sblatz
Copy link
Contributor

sblatz commented Sep 27, 2019

QA: Can we check that this is still happening now that we have a media notification?

@sblatz sblatz added the eng:qa:needed QA Needed label Sep 27, 2019
@sv-ohorvath
Copy link
Contributor

@sblatz I checked and it's still an issue with soundcloud which doesn't show a media notification (#4793 ), other streams like rock.fm or irlpodcast.org don't get interrupted/scrambled.

@sv-ohorvath sv-ohorvath removed the eng:qa:needed QA Needed label Oct 1, 2019
@sblatz
Copy link
Contributor

sblatz commented Dec 26, 2019

@sv-ohorvath are you only able to reproduce this on sites that do not show a media notification?

If that's the case, then I think this bug is expected behavior for those sites. We're not displaying a notification so the system won't give us priority to play audio and it will distort as we have no memory.

If this is failing for ANY site that HAS a notification, I think we should keep this open.

@sblatz sblatz added the eng:qa:needed QA Needed label Dec 26, 2019
@AndiAJ AndiAJ removed the eng:qa:needed QA Needed label Dec 27, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Dec 27, 2019

Hi, I've just checked this matter on the latest Nightly Build #13610606 from 12/27 using a Google Pixel 3a (Android 9)

Soundcloud - doesn't play in the background anymore. #7369

Twitch - The notification is displayed, if you exit to the Fenix homescreen, or navigate to another app the playback is stopped after a couple of seconds (not instantaneously)

HOT97 - Doesn't display any notification, after you navigate to other apps the quality of the sound is altered. (compared it against Chrome)
Another worth mentioning fact is that no media playback notification is displayed in Fenix #7370

Vimeo - The media notification is displayed, no inconsistencies while having Fenix in background

@sblatz - Please review and share your thoughts on this. ☺️
I'll remove the QA needed label.

@sblatz
Copy link
Contributor

sblatz commented Dec 30, 2019

Twitch - The notification is displayed, if you exit to the Fenix homescreen, or navigate to another app the playback is stopped after a couple of seconds (not instantaneously)

Ah, so here's the bug we need to fix then :) I'm going to throw this on the AC bug board as it's likely a fix we need there.

Thanks for this investigation @AndiAJ!

@sblatz
Copy link
Contributor

sblatz commented Jan 6, 2020

@vesta0 is this something we want to prioritize?

@st3fan
Copy link
Contributor

st3fan commented Jan 6, 2020

Looping @pocmo in because I think he did the work on the notifications that we show now.

@vesta0 vesta0 added P1 Current sprint needs:ac Needs Android Component Work and removed P2 Upcoming release labels Jan 10, 2020
@pocmo
Copy link
Contributor

pocmo commented Mar 9, 2020

For those pages GeckoView doesn't tell us about media elements:
https://bugzilla.mozilla.org/show_bug.cgi?id=1554297

@jonalmeida jonalmeida added the needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org label Mar 9, 2020
@ekager ekager added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Apr 11, 2020
@data-sync-user data-sync-user changed the title [Bug] Audio playing in background is distorted after a little bit FNX3-15581 ⁃ [Bug] Audio playing in background is distorted after a little bit Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15581 ⁃ [Bug] Audio playing in background is distorted after a little bit FNX-460 ⁃ [Bug] Audio playing in background is distorted after a little bit Aug 11, 2020
@kbrosnan kbrosnan changed the title FNX-460 ⁃ [Bug] Audio playing in background is distorted after a little bit [Bug] Audio playing in background is distorted after a little bit Aug 25, 2020
@amedyne amedyne removed needs:ac Needs Android Component Work needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Jan 28, 2021
@amedyne
Copy link
Contributor

amedyne commented Jan 28, 2021

Closing, this is already fixed.

@amedyne amedyne closed this as completed Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Media P1 Current sprint
Projects
None yet
Development

No branches or pull requests