Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Soundcloud: Audio plays without media notification showing #4793

Closed
agi90 opened this issue Aug 17, 2019 · 18 comments
Closed

[Bug] Soundcloud: Audio plays without media notification showing #4793

agi90 opened this issue Aug 17, 2019 · 18 comments
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Media needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org P2 Upcoming release 🙅 waiting Issues that are blocked or has dependencies that are not ready

Comments

@agi90
Copy link
Contributor

agi90 commented Aug 17, 2019

Steps to reproduce

  • Play a song (e.g. on soundcloud.com) on Fenix
  • Put Fenix in the background
  • Open a CustomTab from Twitter app (or another app)
  • Open app list and swipe Fenix away

Expected behavior

  • Music should stop, or a notification that music is playing from Fenix should display

Actual behavior

  • Music keeps playing, no way for the user to stop it (beside using Force Stop, which is a pretty obscure UX)

Device information

  • Android device: Samsung S10, Android 9
  • Fenix version: Latest Nightly from today

┆Issue is synchronized with this Jira Task

@agi90 agi90 added the 🐞 bug Crashes, Something isn't working, .. label Aug 17, 2019
@agi90
Copy link
Contributor Author

agi90 commented Aug 19, 2019

Looks like this is specific to soundcloud.com and it's due to https://bugzilla.mozilla.org/show_bug.cgi?id=1554297

@pocmo pocmo added Feature:Media needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org labels Sep 12, 2019
@pocmo pocmo changed the title [Bug] Audio still plays when no Fenix instance is visible [Bug] soundscloud: Audio plays without media notification showing Sep 25, 2019
@vesta0 vesta0 added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Dec 16, 2019
@boek
Copy link
Contributor

boek commented Dec 28, 2019

Is this still an issue @agi90?

@boek boek added the P2 Upcoming release label Dec 28, 2019
@kbrosnan
Copy link
Contributor

According to #1461 this is still an issue.

@liuche
Copy link
Contributor

liuche commented Mar 27, 2020

If we want to make this a priority, we'll need to comment in the bugzilla issue https://bugzilla.mozilla.org/show_bug.cgi?id=1554297

@fluffyemily
Copy link

This will be fixed by the implementation of a new Media standard, the Media Session API. There are a number of parts to this, including implementing it in Gecko and then exposing it through GeckoView. The design phase of this is under way, with implementation expected to occur in GeckoView 79. Please ping me if you want to gain access to the design doc for the spec.

@agi90
Copy link
Contributor Author

agi90 commented May 19, 2020

@lobontiumira
Copy link

I've encountered the same issue using rockfm.ro on the latest beta 5.1.0-beta.1 build with Samsung Galaxy Tab S6 (Android 9).

@fluffyemily
Copy link

This is being tracked under https://bugzilla.mozilla.org/show_bug.cgi?id=1623715. The implementation of Media Session inside Gecko is a pretty big task and is likely to take longer than a single release cycle. Earliest possible GV for this landing is probably GV 80.

@ekager ekager changed the title [Bug] soundscloud: Audio plays without media notification showing [Bug] Soundcloud: Audio plays without media notification showing Aug 1, 2020
@liuche
Copy link
Contributor

liuche commented Oct 8, 2020

Now that this AC issue has landed mozilla-mobile/android-components#8207, let's QA this on Nightly with the next AC version, on Friday Oct 9. EDIT: Due to AC PR problems today and Play Store review times, let's test on Monday Oct 12.

Related issues would be: #7369 #10740

@liuche liuche added the eng:qa:needed QA Needed label Oct 8, 2020
@lobontiumira
Copy link

This is not fixed yet on the 10/9 Nightly build (AC: 63.0.20201008190100, 6249bacf5, GV: 83.0a1-20201008094950) on HTC 10 (Android 8).
Following the STR from the first comment, only force closing Fenix stopped the media from playing.

I'll remove the qa:needed label.

@AndiAJ
Copy link
Collaborator

AndiAJ commented Dec 10, 2020

Hi, verified as fixed on the latest Nightly 201210 using the following devices:
• Google Pixel 3a (Android 11)
• Huawei Mate 20 Lite (Android 10)
• OnePlus A3 (Android 6.0.1)

@AndiAJ AndiAJ closed this as completed Dec 10, 2020
@AndiAJ AndiAJ added the eng:qa:verified QA Verified label Dec 10, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Dec 17, 2020

Still reproducible on Beta 85.0.0-beta.1 using a OnePlus A3 (Android 6.0.1)

@ebalazs-sv
Copy link

This issue is still reproducible on Beta 85.0.0-beta.6 with Nexus 5 (Android 6.0.1).

@alastor0325
Copy link

FYI, on Nightly86.0a1, I am not able to reproduce this issue any more, Firefox shows the media notification controller while playing music on Soundclound.

@lobontiumira
Copy link

Still reproducible on Beta 85.0.0-beta.7 with Sony Xperia Z5 Premium (Android 7.1.1).
I'll reopen this issue.

@lobontiumira lobontiumira reopened this Jan 12, 2021
@pocmo
Copy link
Contributor

pocmo commented Jan 13, 2021

@softvision-miralobontiu / @ebalazs-sv This is not enabled in Beta yet. It was kept behind a feature flag. It's in Nightly currently and should go into the next Beta.

@pocmo pocmo closed this as completed Jan 13, 2021
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jan 21, 2021

Still reproducible on 85.1.0-rc.1 using a OnePlus A3 (Android 6.0.1)

@AndiAJ
Copy link
Collaborator

AndiAJ commented Feb 9, 2021

Still reproducible on 85.1.3 using a OnePlus A3 (Android 6.0.1)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Media needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org P2 Upcoming release 🙅 waiting Issues that are blocked or has dependencies that are not ready
Projects
None yet
Development

No branches or pull requests