Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Show which tab is playing audio #1114

Closed
pocmo opened this issue Mar 21, 2019 · 17 comments
Closed

Show which tab is playing audio #1114

pocmo opened this issue Mar 21, 2019 · 17 comments
Assignees
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified Feature:Media
Milestone

Comments

@pocmo
Copy link
Contributor

pocmo commented Mar 21, 2019

User Story

As a user I want to know which tab is playing audio and be able to pause each tab, so I know where audio is coming from specially when I have multiple tabs open.

Acceptance Criteria:

-I can see which tab is playing audio
-I can easily pause audio for each tab

┆Issue is synchronized with this Jira Task

@vesta0 vesta0 added the P2 Upcoming release label Apr 1, 2019
@vesta0 vesta0 added this to the Backlog (After MVP) milestone Apr 1, 2019
@vesta0 vesta0 added should and removed P2 Upcoming release labels Jul 2, 2019
@vesta0 vesta0 changed the title As a user I want to know which tab is playing audio Show which tab is playing audio Jul 9, 2019
@vesta0 vesta0 modified the milestone: Feature Backlog Jul 26, 2019
@vesta0 vesta0 mentioned this issue Jul 29, 2019
7 tasks
@vesta0
Copy link
Collaborator

vesta0 commented Aug 9, 2019

@topotropic just a note to think about accessibility of the playback controls (e.g. too close to close tab x), dark mode, and landscape mode

@vesta0 vesta0 added the E5 Estimation Point: about 5 days label Aug 9, 2019
@topotropic
Copy link

topotropic commented Aug 20, 2019

Screen Shot 2019-08-30 at 10 31 33 AM

Icon color inactive (play):

  • light theme: disabled_light_theme 
#6620123A
  • dark theme: disabled_dark_theme 
#66FBFBFE
  • private theme: disabled_private_theme 
#66FBFBFE

Icon color active (pause):

  • light theme: accent_bright_light_theme 
#592ACB
  • dark theme: accent_bright_dark_theme 
#592ACB
  • private theme: accent_bright_private_theme 
#592ACB

touch target size for play/pause button is 48dp
1114-home-tile-with-play-button.pdf
icons.zip

@liuche
Copy link
Contributor

liuche commented Aug 30, 2019

Questions:

  • is this too busy? Potentially discuss with UX (or not)
  • Verify that we have the API to determine which tab is playing.

@pocmo
Copy link
Contributor Author

pocmo commented Aug 30, 2019

AC exposed that state already. I filed the linked issue above to add some more convenient helpers to examine that state.

@boek boek added this to the v2.0 milestone Sep 4, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Sep 11, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Sep 11, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Sep 11, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Sep 11, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Sep 11, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Sep 11, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Sep 11, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Sep 11, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Sep 11, 2019
sblatz added a commit that referenced this issue Sep 11, 2019
@sblatz sblatz added the eng:qa:needed QA Needed label Sep 11, 2019
@LaurentiuApahideanSV
Copy link

The play/pause button is not shown when listening from www.soundcloud.com or www.untold.com, issue #4793 might be related.

@pocmo
Copy link
Contributor Author

pocmo commented Sep 12, 2019

Yeah, that's the same reason as #4793 and depends on this GV bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1554297

@sv-ohorvath
Copy link
Contributor

Verified as fixed on 2.0.0-rc2

@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 13, 2019
@data-sync-user data-sync-user changed the title Show which tab is playing audio FNX2-16355 ⁃ Show which tab is playing audio Jul 31, 2020
@data-sync-user data-sync-user changed the title FNX2-16355 ⁃ Show which tab is playing audio FNX3-14419 ⁃ Show which tab is playing audio Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-14419 ⁃ Show which tab is playing audio FNX-4807 ⁃ Show which tab is playing audio Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-4807 ⁃ Show which tab is playing audio FNX2-16355 ⁃ Show which tab is playing audio Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16355 ⁃ Show which tab is playing audio Show which tab is playing audio May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified Feature:Media
Projects
None yet
Development

No branches or pull requests

9 participants