Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Add helpers to determine and modify media state #4161

Closed
pocmo opened this issue Aug 20, 2019 · 1 comment
Closed

Add helpers to determine and modify media state #4161

pocmo opened this issue Aug 20, 2019 · 1 comment
Assignees
Labels
🌟 feature New functionality and improvements <media> Component: feature-media
Milestone

Comments

@pocmo
Copy link
Contributor

pocmo commented Aug 20, 2019

For implementing this in Fenix it would be helpful to have some helpers in AC that make it easier to determine and modify the media state of a Session:
mozilla-mobile/fenix#1114

┆Issue is synchronized with this Jira Task

@pocmo pocmo added 🌟 feature New functionality and improvements <media> Component: feature-media labels Aug 20, 2019
@pocmo pocmo self-assigned this Sep 6, 2019
@pocmo
Copy link
Contributor Author

pocmo commented Sep 9, 2019

After talking to Sawyer it turns out that all we need to do is to make MediaState.pauseIfPlaying() and MediaState.playIfPaused() public.

@pocmo pocmo added this to the 🍉 12.0.0 milestone Sep 9, 2019
bors bot pushed a commit that referenced this issue Sep 9, 2019
4351: Closes #4161: Make MediaState extension methods visible for consuming apps. r=csadilek a=pocmo



4360: Closes #4350: Allow for a missing `action` param in FxA auth flows r=jonalmeida a=grigoryk

It's possible that `action` parameter may be missing. This patch adds handling for that case,
and tests for the interceptor (which were missing entirely) that cover all combinations.




Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
@bors bors bot closed this as completed in 2b25394 Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🌟 feature New functionality and improvements <media> Component: feature-media
Projects
None yet
Development

No branches or pull requests

1 participant