This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Closes #4350: Allow for a missing action param in FxA auth flows
#4360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonalmeida
approved these changes
Sep 9, 2019
| @@ -72,6 +72,9 @@ permalink: /changelog/ | |||
| * **feature-pwa** | |||
| * Adds the ability to create a basic shortcut with a custom label | |||
|
|
|||
| * **concept-sync** | |||
| * ⚠️ **This is a breaking change**: `action` param of `AuthType.OtherExternal` is now optional. Missing `action` indicates that we really don't know what external authType we've hit. | |||
There was a problem hiding this comment.
nit: I don't think it's a breaking change since we're going from required -> optional.
There was a problem hiding this comment.
It's a breaking change for consumers of AuthType. If they relied on action as being always present, now it's not the case.
|
bors r+ @grigoryk need to fix the conflict though. |
Merge conflict |
… auth flows It's possible that `action` parameter may be missing. This patch adds handling for that case, and tests for the interceptor (which were missing entirely) that cover all combinations.
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Sep 9, 2019
4360: Closes #4350: Allow for a missing `action` param in FxA auth flows r=jonalmeida a=grigoryk It's possible that `action` parameter may be missing. This patch adds handling for that case, and tests for the interceptor (which were missing entirely) that cover all combinations. Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
Timed out |
|
bors r=jonalmeida |
bors bot
pushed a commit
that referenced
this pull request
Sep 9, 2019
4351: Closes #4161: Make MediaState extension methods visible for consuming apps. r=csadilek a=pocmo 4360: Closes #4350: Allow for a missing `action` param in FxA auth flows r=jonalmeida a=grigoryk It's possible that `action` parameter may be missing. This patch adds handling for that case, and tests for the interceptor (which were missing entirely) that cover all combinations. Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com> Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible that
actionparameter may be missing. This patch adds handling for that case,and tests for the interceptor (which were missing entirely) that cover all combinations.
Pull Request checklist
After merge