Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Telemetry] Sync Tabs #15369

Closed
7 tasks
vesta0 opened this issue Sep 24, 2020 · 4 comments
Closed
7 tasks

[Telemetry] Sync Tabs #15369

vesta0 opened this issue Sep 24, 2020 · 4 comments

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Sep 24, 2020

Description & Product Manager / Data Scientist User Story

As a product manager, I want to understand how often our users access their synced tabs in the browser, so I can prioritize related features accordingly.

What questions will you answer with this data?

  • How often (and what % of users) tap on a synced tab to open it in browser?

Acceptance Criteria

  • ENG files a DS JIRA request outlining their methodology.
  • DS sign off on instrumentation methodology addressing product questions.
  • Event pings can be queried via re:dash
  • Event pings can be queried via amplitude
  • We are sending telemetry events for the actions listed in the requirements
  • We have documented the telemetry
  • We have asked a data steward to review the telemetry

┆Issue is synchronized with this Jira Task

@vesta0 vesta0 added the Skittle label Sep 24, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 24, 2020
@vesta0 vesta0 removed the needs:triage Issue needs triage label Sep 24, 2020
@mcarare mcarare self-assigned this Nov 24, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Nov 24, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Nov 24, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Nov 24, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Nov 24, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Dec 7, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Dec 7, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Dec 7, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Dec 7, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Dec 7, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Dec 7, 2020
@Mugurell
Copy link
Contributor

Mugurell commented Dec 10, 2020

Talked offline with Kate who confirmed with DS and Boek:

  • The newly added metrics should log events, not counters anymore
  • An an expiration date 6 months is preferred.
    Maybe if there is already related telemetry for that part of the screen / feature we can reuse the existing expiration date so that all related telemetry probes will be renewed at the same time.

mcarare added a commit to mcarare/fenix that referenced this issue Dec 10, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Dec 10, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Dec 10, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Dec 10, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Dec 10, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Dec 10, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Dec 15, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Dec 15, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Dec 15, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Dec 15, 2020
@mcarare mcarare added the eng:qa:needed QA Needed label Dec 15, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Dec 16, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Dec 16, 2020

Hi, I've just checked this matter on the latest Nightly 201216 using a Google Pixel 3a (Android 11) and it seems that the corresponding event type ping isn't generated.

@mcarare please review

@AndiAJ AndiAJ removed the eng:qa:needed QA Needed label Dec 16, 2020
@mcarare
Copy link
Contributor

mcarare commented Dec 16, 2020

Hi, I've just checked this matter on the latest Nightly 201216 using a Google Pixel 3a (Android 11) and it seems that the corresponding event type ping isn't generated.

@mcarare please review

Should be good to go, after the latest changes.

@mcarare mcarare added the eng:qa:needed QA Needed label Dec 16, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Dec 18, 2020

Hi, verified as fixed on the latest Nightly 201218 using a Google Pixel 3a (Android 11)

✔️ Open a synced tab from the page view ⋮ Main menu - Ping 25091ba1-9635-44b5-8166-71cb624050c7
✔️ Open a synced tab from the home screen ⋮ Main menu - Ping 68e0f9f3-f0e2-47e4-a7dd-a42cdc68b6d4

{
          "category": "events",
          "name": "synced_tab_opened",
          "timestamp": 6905
        }

Logcat
Glean dashboard

@AndiAJ AndiAJ closed this as completed Dec 18, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Dec 18, 2020
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants