Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Telemetry] Share image #16076

Closed
4 of 7 tasks
vesta0 opened this issue Oct 21, 2020 · 5 comments
Closed
4 of 7 tasks

[Telemetry] Share image #16076

vesta0 opened this issue Oct 21, 2020 · 5 comments

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Oct 21, 2020

Description & Product Manager / Data Scientist User Story

We are currently tracking all the actions listed in the Image Selection Action Menu (we call it context_menu.item_tapped) except for Share Image.

As a product manager, I want to know how often users share an image to a third party app or another device, so I can measure whether improvements to this feature will help our users.

What questions will you answer with this data?

  • How many users (and how often) share an image in a day?

Acceptance Criteria

  • ENG filed a DS JIRA outlining the telemetry request.
  • DS sign off on instrumentation methodology addressing product questions.
  • Event pings can be queried via re:dash
  • Event pings can be queried via amplitude
  • We are sending telemetry events for the actions listed in the requirements
  • We have documented the telemetry
  • We have asked a data steward to review the telemetry

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 21, 2020
@vesta0 vesta0 added Feature:Sharing and removed needs:triage Issue needs triage labels Oct 21, 2020
@Mugurell Mugurell self-assigned this Nov 11, 2020
@Mugurell
Copy link
Contributor

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1) What questions will you answer with this data?
How often users share an image from the app.

2) Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
Measure whether improvements to this feature will help our users.

3) What alternative methods did you consider to answer these questions? Why were they not sufficient?
There is the only way. We are currently tracking all the actions listed in the Image Selection Action Menu (we call it context_menu.item_tapped) except for Share Image.

4) Can current instrumentation answer these questions?
No. We need a new specific event for a specific app feature.

5) List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

Measurement Description Data Collection Category Tracking Bug #
Share image events Category 2 https://github.com//issues/16076

6) Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.
This collection is documented in the metrics.md document document included in the project - https://github.com/mozilla-mobile/fenix/blob/master/docs/metrics.md

7) How long will this data be collected? Choose one of the following:
Based on #13958 (comment) until 2021-04-01.
Pending renewal.

8) What populations will you measure?
All release channels and locales.

9) If this data collection is default on, what is the opt-out mechanism for users?
Users can opt of of data collection by disabling Usage and technical data from Settings -> Data collection.

10) Please provide a general description of how you will analyze this data.
Glean / Amplitude

11) Where do you intend to share the results of your analysis?
Only on Glean, Amplitude and with mobile teams.

12) Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?
No.

@Mugurell Mugurell added the needs:data-review PR is awaiting a data review label Nov 11, 2020
@Mugurell
Copy link
Contributor

@boek Can you help with a data review?

ekager pushed a commit that referenced this issue Nov 11, 2020
A link for the "share_image" data review is to be added after review.
@boek
Copy link
Contributor

boek commented Nov 12, 2020

data-review r+

Data Review Form (to be filled by Data Stewards)

Instructions: Data Stewards will review a request for data collection and endorse responses to each question. If the request does not provide answers to questions, reviewers give an r- and point to the questions that can’t be answered.

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
    Yes, metrics.md and metrics.yaml

  2. Is there a control mechanism that allows the user to turn the data collection on and off?
    Yes data controls in fenix settings

  3. If the request is for permanent data collection, is there someone who will monitor the data over time?
    Modifies existing metric, expires "2021-04-01". Fenix team will monitor

  4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
    Type 2

  5. Is the data collection request for default-on or default-off?
    Default on

  6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
    No

  7. Is the data collection covered by the existing Firefox privacy notice?
    Yes

  8. Does there need to be a check-in in the future to determine whether to renew the data?
    Will check-in at expirey

  9. Does the data collection use a third-party collection tool?
    No

@Mugurell
Copy link
Contributor

With this being already merged I think it's ready to be tested.

@Mugurell Mugurell added eng:qa:needed QA Needed and removed needs:data-review PR is awaiting a data review labels Nov 18, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Nov 19, 2020

Hi, verified as fixed on both the latest Nightly 2011192 and Beta 84.0.0-beta.1 using a Google Pixel 3a (Android 11)

► Nightly 201119
✔️ Share image - context menu from a link - Ping b98123a5-9520-41a3-894d-3a8914bf346c
✔️ Share image - context menu from the picture itself - Ping f5e5567b-be7b-4e06-aea6-405fa655d112

Glean dashboard
Logcat

► Beta 84.0.0-beta.1
✔️ Share image - context menu from a link - Ping a87e0464-8716-48c1-baa9-d98d559cf956
✔️ Share image - context menu from the picture itself - Ping 93e643d1-f3ec-414a-ad55-e87178cdf153

Glean dashboard
Logcat

{
          "category": "context_menu",
          "extra": {
            "named": "share_image"
          },
          "name": "item_tapped",
          "timestamp": 8933
        }

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants