Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Don't list about:* pages in history results #1614

Closed
Verdi opened this issue Apr 12, 2019 · 3 comments
Closed

Don't list about:* pages in history results #1614

Verdi opened this issue Apr 12, 2019 · 3 comments
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Search P2 Upcoming release 🙅 waiting Issues that are blocked or has dependencies that are not ready
Milestone
Bugs and Polish

Comments

@Verdi
Copy link

Verdi commented Apr 12, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

  • Visit any about:* page
  • Start a search with the term "about"

Expected behavior

  • I should not see suggestions for internal pages.

Actual behavior

  • I see suggestions for about:* pages

Device information

  • Android device: ?
  • Fenix version: 1.0.1915 Build #11021216

┆Issue is synchronized with this Jira Task
@Verdi Verdi added 🐞 bug Crashes, Something isn't working, .. Search labels Apr 12, 2019
@pocmo
Copy link
Contributor

pocmo commented Apr 17, 2019

Related: mozilla-mobile/android-components#2606

@vesta0 vesta0 added the P2 Upcoming release label Apr 24, 2019
@vesta0 vesta0 added this to the Bugs milestone Apr 24, 2019
@vesta0 vesta0 added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Apr 30, 2019
@bifleming
Copy link

@pocmo do you know if this is still blocked? I see that the related a-c bug has been closed.

@ekager
Copy link
Contributor

ekager commented Jun 26, 2019

This is fixed now and these domains are filtered out by AC HistoryDelegate

@ekager ekager closed this as completed Jun 26, 2019
@data-sync-user data-sync-user changed the title Don't list about:* pages in history results FNX2-17262 ⁃ Don't list about:* pages in history results Aug 4, 2020
@data-sync-user data-sync-user changed the title FNX2-17262 ⁃ Don't list about:* pages in history results FNX3-15683 ⁃ Don't list about:* pages in history results Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15683 ⁃ Don't list about:* pages in history results FNX-5134 ⁃ Don't list about:* pages in history results Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-5134 ⁃ Don't list about:* pages in history results Don't list about:* pages in history results May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Search P2 Upcoming release 🙅 waiting Issues that are blocked or has dependencies that are not ready
Projects
None yet
Milestone
Bugs and Polish
Development

No branches or pull requests
7 participants
@pocmo @Verdi @kbrosnan @ekager @vesta0 @bifleming @data-sync-user