This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
History: Ignore initial load of about:blank #2606
Assignees
Labels
🐞 bug
Something isn't working
<engine-gecko>
Component: browser-engine-gecko
🐉 Fenix
Feature needed for Fenix
P1
<storage>
Concerning general browser storage
Milestone
Comments
pocmo
added
🐞 bug
|
FYI @grigoryk |
|
Our HistoryDelegate is probably a good place to do this filtering. |
|
We also currently insert custom home page extension URLs, e.g. |
ghost
added
This was referenced Apr 17, 2019
|
Here's this logic in Fennec. We probably just want to port it over: https://dxr.mozilla.org/mozilla-central/source/mobile/android/components/build/nsAndroidHistory.cpp#326 |
grigoryk
pushed a commit
to grigoryk/android-components
that referenced
this issue
Apr 26, 2019
grigoryk
pushed a commit
to grigoryk/android-components
that referenced
this issue
Apr 26, 2019
grigoryk
pushed a commit
to grigoryk/android-components
that referenced
this issue
Apr 26, 2019
grigoryk
pushed a commit
to grigoryk/android-components
that referenced
this issue
Apr 26, 2019
grigoryk
pushed a commit
to grigoryk/android-components
that referenced
this issue
Apr 30, 2019
grigoryk
pushed a commit
to grigoryk/android-components
that referenced
this issue
Apr 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Fenix issue: mozilla-mobile/fenix#1318
A
GeckoSessionwill always start by loadingabout:blankand there are technical reasons why that is the case.In
GeckoEngineSession.onLocationChange()we ignore the initial load (added in #403):https://github.com/mozilla-mobile/android-components/blob/master/components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/GeckoEngineSession.kt#L282-L286
We don't do that for history though. And therefore every time you open a tab we track an
about:blankvisit.┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: