Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

engine-gecko-*: Ignore first load of about:blank #403

Closed
pocmo opened this issue Jul 10, 2018 · 1 comment
Closed

engine-gecko-*: Ignore first load of about:blank #403

pocmo opened this issue Jul 10, 2018 · 1 comment
Assignees
@csadilek
Labels
<engine-gecko> Component: browser-engine-gecko
Milestone
0.15 🌈

Comments

@pocmo
Copy link
Contributor

pocmo commented Jul 10, 2018 •
edited by data-sync-user
Loading

GeckoView always loads about:blank as the first thing it does. And we end up showing this briefly in the URL bar.

Apparently that's a Gecko thing and we have to live with that for now. Let's ignore that and do not forward this to the observers of the engine session.

Fennec does all kinds of things to work around that too, e.g.:

┆Issue is synchronized with this Jira Task
@pocmo pocmo added the <engine-gecko> Component: browser-engine-gecko label Jul 10, 2018
@pocmo pocmo added this to the 0.15 🌈 milestone Jul 13, 2018
@csadilek csadilek self-assigned this Jul 17, 2018
csadilek added a commit to csadilek/android-components that referenced this issue Jul 17, 2018
@csadilek
Closes mozilla-mobile#403: Ignore first load of about:blank in engine…
fe39b7a 
…-gecko
csadilek added a commit to csadilek/android-components that referenced this issue Jul 17, 2018
@csadilek
Closes mozilla-mobile#403: Ignore first load of about:blank in engine…
378ce32 
…-gecko
csadilek added a commit to csadilek/android-components that referenced this issue Jul 17, 2018
@csadilek
Closes mozilla-mobile#403: Ignore first load of about:blank in engine…
3b94a70 
…-gecko
csadilek added a commit to csadilek/android-components that referenced this issue Jul 18, 2018
@csadilek
Closes mozilla-mobile#403: Ignore first load of about:blank in engine…
2c52304 
…-gecko
@pocmo pocmo closed this as completed in 64b032c Jul 18, 2018
@pocmo pocmo mentioned this issue Apr 2, 2019
Closed
bors bot pushed a commit that referenced this issue Nov 14, 2019
@MozLando @espertus @dependabot
Merge #4974 #5045
cb68475 
4974: Add library for P2P communication and sample app r=jonalmeida a=espertus

Add library for P2P communication and sample app

This adds `lib-nearby` on top of the Google Play Nearby API.
The sample app `nearby-chat` uses it to create a chat application enabling
communication between 2 devices.

This is a better version of #4794 because it is a single commit.



5045: Bump rubyzip from 1.2.3 to 2.0.0 in /docs r=pocmo a=dependabot[bot]

Bumps [rubyzip](https://github.com/rubyzip/rubyzip) from 1.2.3 to 2.0.0.
<details>
<summary>Release notes</summary>

*Sourced from [rubyzip's releases](https://github.com/rubyzip/rubyzip/releases).*

> ## v2.0.0
> Security
> 
> - Default the `validate_entry_sizes` option to `true`, so that callers can trust an entry's reported size when using `extract` [#403](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/403)
>    - This option defaulted to `false` in 1.3.0 for backward compatibility, but it now defaults to `true`. If you are using an older version of ruby and can't yet upgrade to 2.x, you can still use 1.3.0 and set the option to `true`.
> 
> Tooling / Documentation
> 
> - Remove test files from the gem to avoid problems with antivirus detections on the test files [#405](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/405) / [#384](https://github-redirect.dependabot.com/rubyzip/rubyzip/issues/384)
> - Drop support for unsupported ruby versions [#406](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/406)
> 
> ## v1.3.0
> Security
> 
> - Add `validate_entry_sizes` option so that callers can trust an entry's reported size when using `extract` [#403](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/403)
>    - This option defaults to `false` for backward compatibility in this release, but you are strongly encouraged to set it to `true`. It will default to `true` in rubyzip 2.0.
> 
> New Feature
> 
> - Add `add_stored` method to simplify adding entries without compression [#366](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/366)
> 
> Tooling / Documentation
> 
> - Add more gem metadata links [#402](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/402)
> 
> ## v1.2.4
> - Do not rewrite zip files opened with `open_buffer` that have not changed [#360](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/360)
> 
> Tooling / Documentation
> 
> - Update `example_recursive.rb` in README [#397](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/397)
> - Hold CI at `trusty` for now, automatically pick the latest ruby patch version, use rbx-4 and hold jruby at 9.1 [#399](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/399)
</details>
<details>
<summary>Changelog</summary>

*Sourced from [rubyzip's changelog](https://github.com/rubyzip/rubyzip/blob/master/Changelog.md).*

> # 2.0.0 (2019-09-25)
> 
> Security
> 
> - Default the `validate_entry_sizes` option to `true`, so that callers can trust an entry's reported size when using `extract` [#403](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/403)
>    - This option defaulted to `false` in 1.3.0 for backward compatibility, but it now defaults to `true`. If you are using an older version of ruby and can't yet upgrade to 2.x, you can still use 1.3.0 and set the option to `true`.
> 
> Tooling / Documentation
> 
> - Remove test files from the gem to avoid problems with antivirus detections on the test files [#405](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/405) / [#384](https://github-redirect.dependabot.com/rubyzip/rubyzip/issues/384)
> - Drop support for unsupported ruby versions [#406](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/406)
> 
> # 1.3.0 (2019-09-25)
> 
> Security
> 
> - Add `validate_entry_sizes` option so that callers can trust an entry's reported size when using `extract` [#403](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/403)
>    - This option defaults to `false` for backward compatibility in this release, but you are strongly encouraged to set it to `true`. It will default to `true` in rubyzip 2.0.
> 
> New Feature
> 
> - Add `add_stored` method to simplify adding entries without compression [#366](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/366)
> 
> Tooling / Documentation
> 
> - Add more gem metadata links [#402](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/402)
> 
> # 1.2.4 (2019-09-06)
> 
> - Do not rewrite zip files opened with `open_buffer` that have not changed [#360](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/360)
> 
> Tooling / Documentation
> 
> - Update `example_recursive.rb` in README [#397](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/397)
> - Hold CI at `trusty` for now, automatically pick the latest ruby patch version, use rbx-4 and hold jruby at 9.1 [#399](https://github-redirect.dependabot.com/rubyzip/rubyzip/pull/399)
</details>
<details>
<summary>Commits</summary>

- [`2825898`](rubyzip/rubyzip@2825898) Merge pull request [#408](https://github-redirect.dependabot.com/rubyzip/rubyzip/issues/408) from rubyzip/v2-0-0
- [`cb407b1`](rubyzip/rubyzip@cb407b1) Bump version to 2.0.0
- [`e1d9af6`](rubyzip/rubyzip@e1d9af6) Merge pull request [#406](https://github-redirect.dependabot.com/rubyzip/rubyzip/issues/406) from rubyzip/bump-supported-ruby
- [`3641a96`](rubyzip/rubyzip@3641a96) Merge pull request [#405](https://github-redirect.dependabot.com/rubyzip/rubyzip/issues/405) from rubyzip/remove-test-files
- [`e79d9ea`](rubyzip/rubyzip@e79d9ea) Merge pull request [#407](https://github-redirect.dependabot.com/rubyzip/rubyzip/issues/407) from rubyzip/v1-3-0
- [`7c65e1e`](rubyzip/rubyzip@7c65e1e) Bump version to 1.3.0
- [`d65fe7b`](rubyzip/rubyzip@d65fe7b) Merge pull request [#403](https://github-redirect.dependabot.com/rubyzip/rubyzip/issues/403) from rubyzip/check-size
- [`35446f4`](rubyzip/rubyzip@35446f4) Drop old ruby and JDK versions from CI
- [`74d4bec`](rubyzip/rubyzip@74d4bec) Remove test files from gem
- [`97cb6ae`](rubyzip/rubyzip@97cb6ae) Warn when an entry size is invalid
- Additional commits viewable in [compare view](rubyzip/rubyzip@v1.2.3...v2.0.0)
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=rubyzip&package-manager=bundler&previous-version=1.2.3&new-version=2.0.0)](https://help.github.com/articles/configuring-automated-security-fixes)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)



Co-authored-by: Ellen Spertus <ellen.spertus@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@csadilek csadilek mentioned this issue Oct 16, 2020
Closed
@csadilek
Copy link
Contributor

In #8724, we're now also handing onPageStop/onPageStart which are the only other observers we have affected by the initial about:blank load.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@csadilek csadilek

Labels
<engine-gecko> Component: browser-engine-gecko
Projects
None yet
Milestone
0.15 🌈
Development

No branches or pull requests
2 participants
@pocmo @csadilek