Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Paste behavior improvements #16249

Closed
Mugurell opened this issue Oct 29, 2020 · 3 comments
Closed

[Bug] Paste behavior improvements #16249

Mugurell opened this issue Oct 29, 2020 · 3 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified needs:investigation

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Oct 29, 2020

Following https://bugzilla.mozilla.org/show_bug.cgi?id=1664746 we should look for potential improvements.

┆Issue is synchronized with this Jira Task

@Mugurell Mugurell added 🐞 bug Crashes, Something isn't working, .. hershey labels Oct 29, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 29, 2020
@Mugurell Mugurell removed the needs:triage Issue needs triage label Oct 29, 2020
@mcarare mcarare self-assigned this Oct 30, 2020
@mcarare mcarare removed their assignment Jan 4, 2021
@Mugurell
Copy link
Contributor Author

Mugurell commented Jan 4, 2021

I saw in Fenix we are using our own https://github.com/mozilla-mobile/fenix/blob/07748f69b75144e8e247b742f66a756f999cb299/app/src/main/java/org/mozilla/fenix/utils/ClipboardHandler.kt as a wrapper over the ClipboardManager that would allow us to easily do what we need.

But there is also the InlineAutocompleteEditText from AC which shows it's own floating menu and already responds to onTextContextMenuItem selected items.
For this I was thinking to just do the pasting ourselves similar to what now happens in https://cs.android.com/android/platform/superproject/+/master:frameworks/base/core/java/android/widget/TextView.java;drc=master;l=12891.
Seems to be the simplest and cleanest way to have full control.

Since I see you worked the most on InlineAutocompleteEditText, @csadilek does this seem like a reasonable approach?

@csadilek
Copy link
Contributor

csadilek commented Jan 4, 2021

@Mugurell Yes, sounds reasonable! InlineAutocompleteEditText is a generic UI component though. It doesn't and probably shouldn't have a concept of protocols, but we can address that by providing some form of list / configuration as a parameter?

@abodea
Copy link
Member

abodea commented Jan 19, 2021

Verified as fixed on Nightly 1/19 with Google Pixel 4 XL (11).

@abodea abodea closed this as completed Jan 19, 2021
@abodea abodea added the eng:qa:verified QA Verified label Jan 19, 2021
@sflorean sflorean removed the eng:qa:needed QA Needed label Feb 2, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified needs:investigation
Projects
None yet
Development

No branches or pull requests

5 participants