Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Expose credit card & addresses syncing in Account Settings UI #17537

Closed
grigoryk opened this issue Jan 20, 2021 · 5 comments · Fixed by #19471
Closed

Expose credit card & addresses syncing in Account Settings UI #17537

grigoryk opened this issue Jan 20, 2021 · 5 comments · Fixed by #19471
Assignees
@eliserichards
Labels
a-s Application Services work needed cc-autofill Autofill credit card E2 Estimation Point: easy, half a day to 2 days eng:qa:verified QA Verified Feature:Autofill Address and Credit Card autofill Feature:Sync
Milestone
90

Comments

@grigoryk
Copy link
Contributor

grigoryk commented Jan 20, 2021 •
edited by data-sync-user
Loading

Issue capturing larger eng work: mozilla-mobile/android-components#9452

User Story

  • As a user, I want to be able to enable and disable credit cards syncing
  • As a user, I want to be able to enable and disable addresses syncing

Dependencies

Acceptance Criteria

  • I can do see status of, and enable/disable credit cards syncing under Account Settings
  • I can do see status of, and enable/disable addresses syncing under Account Settings

┆Issue is synchronized with this Jira Task
@grigoryk
Copy link
Contributor Author

This will need to be wired up in AccountsSettingsFragment.

@github-actions github-actions bot added the needs:triage Issue needs triage label Jan 20, 2021
@grigoryk grigoryk mentioned this issue Jan 20, 2021
Closed
@amedyne amedyne removed the needs:triage Issue needs triage label Jan 20, 2021
@gabrielluong gabrielluong added Feature:Autofill Address and Credit Card autofill a-s Application Services work needed blocked needs:ac Needs Android Component Work and removed Feature:Forms labels Mar 2, 2021
@gabrielluong gabrielluong added cc-autofill Autofill credit card E3 Estimation Point: average, 2 - 3 days E2 Estimation Point: easy, half a day to 2 days and removed E3 Estimation Point: average, 2 - 3 days labels Mar 2, 2021
@gabrielluong gabrielluong removed blocked needs:ac Needs Android Component Work labels Apr 26, 2021
@gabrielluong
Copy link
Member

gabrielluong commented Apr 26, 2021 •
edited
Loading

The credit card sync engine should be available with the latest AC/AS update in #19195. We should wire up the UI, but only display it with the credit card autofill pref enabled. I don't know if addresses is available, if it is we could add it and hide it based on the address autofill pref, but otherwise addresses isn't a priority. We can just file a separate ticket to separate the 2 if we ever get to addresses in the future.

@gabrielluong gabrielluong mentioned this issue Apr 26, 2021
Merged
3 tasks
@eliserichards eliserichards self-assigned this May 7, 2021
@gabrielluong gabrielluong added this to the 90 milestone May 7, 2021
@eliserichards
Copy link

Designs: https://www.figma.com/file/cSKRUEvfJSzNBv2Mp65Pdv/Mobile-CC-Autofill?node-id=170%3A6206

@eliserichards
Copy link

image

@eliserichards eliserichards mentioned this issue May 11, 2021
Merged
3 tasks
@eliserichards eliserichards linked a pull request May 11, 2021 that will close this issue
For #17537: Add preferences for syncing credit cards and addresses #19471
Merged
3 tasks
eliserichards pushed a commit that referenced this issue May 13, 2021
For #17537: Add preferences for syncing credit cards and addresses (#…
6459a85 
…19471)

* Add preferences for enable/disable sync for cc and addresses

* Set pref visibility based on feature flags

* Helper function for pin warning preferences and set default values for cc and addresses to false.

* Kdocs for relevant sync functions in account settings

* Default visibility to false for credit cards and addresses in account settings
@eliserichards eliserichards reopened this May 13, 2021
@eliserichards eliserichards added the eng:qa:needed QA Needed label May 13, 2021
@abodea
Copy link
Member

abodea commented May 18, 2021

Verified as fixed on the latest Nightly 5/18 with Google Pixel 4 XL (Android 11).

@abodea abodea closed this as completed May 18, 2021
@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eliserichards eliserichards

Labels
a-s Application Services work needed cc-autofill Autofill credit card E2 Estimation Point: easy, half a day to 2 days eng:qa:verified QA Verified Feature:Autofill Address and Credit Card autofill Feature:Sync
Projects
None yet
Milestone
90
Development

Successfully merging a pull request may close this issue.

For #17537: Add preferences for syncing credit cards and addresses eliserichards/fenix
6 participants
@kbrosnan @grigoryk @gabrielluong @abodea @eliserichards @amedyne