Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Hook up credit cards and addresses storage layers and delegates #17538

Closed
grigoryk opened this issue Jan 20, 2021 · 1 comment · Fixed by #19598
Closed

Hook up credit cards and addresses storage layers and delegates #17538

grigoryk opened this issue Jan 20, 2021 · 1 comment · Fixed by #19598
Assignees
@mcarare
Labels
cc-autofill Autofill credit card E1 Estimation Point: trivial, less than half day Feature:Autofill Address and Credit Card autofill
Milestone
90

Comments

@grigoryk
Copy link
Contributor

grigoryk commented Jan 20, 2021 •
edited by data-sync-user
Loading

Once we have storage layers and delegates available in a-c (see mozilla-mobile/android-components#9452) we can start adding them to Core and hooking them up to a GeckoRuntime instance.

These are slow, encrypted storage layers so it's import to follow the Lazy<T> init pattern here and use the warmUp calls. See FenixApplication#queueInitStorageAndServices and lazy*Storage wrappers in Core.kt.

┆Issue is synchronized with this Jira Task
@github-actions github-actions bot added the needs:triage Issue needs triage label Jan 20, 2021
@grigoryk grigoryk mentioned this issue Jan 20, 2021
Closed
@amedyne amedyne removed the needs:triage Issue needs triage label Jan 20, 2021
@gabrielluong gabrielluong self-assigned this Feb 19, 2021
@gabrielluong gabrielluong added E3 Estimation Point: average, 2 - 3 days cc-autofill Autofill credit card Feature:Autofill Address and Credit Card autofill and removed Feature:Forms labels Mar 2, 2021
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Mar 9, 2021
@gabrielluong
For mozilla-mobile#17538 - Add a lazy getter for AutofillCreditCardsA…
792134f 
…ddressStorage
@gabrielluong gabrielluong added E1 Estimation Point: trivial, less than half day blocked and removed E3 Estimation Point: average, 2 - 3 days labels Mar 9, 2021
@gabrielluong gabrielluong mentioned this issue Mar 9, 2021
Closed
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Mar 11, 2021
@gabrielluong
For mozilla-mobile#17538 - Add a lazy getter for AutofillCreditCardsA…
1d10205 
…ddressStorage
@gabrielluong gabrielluong removed their assignment May 20, 2021
@gabrielluong
Copy link
Member

I think we still need to add a warmUp call in FenixApplication#queueInitStorageAndServices. This will also require AC changes to add a warmUp method. See the SyncableLoginStorage

@gabrielluong gabrielluong added this to the 90 milestone May 20, 2021
@mcarare mcarare self-assigned this May 21, 2021
@mcarare mcarare mentioned this issue May 21, 2021
Closed
mcarare added a commit to mcarare/fenix that referenced this issue May 21, 2021
@mcarare
For mozilla-mobile#17538: Perform autofill storage warm-up after visu…
d7492c5 
…al completeness.
@gabrielluong gabrielluong mentioned this issue May 24, 2021
Merged
3 tasks
mcarare added a commit to mcarare/fenix that referenced this issue May 24, 2021
@mcarare
For mozilla-mobile#17538: Perform autofill storage warm-up after visu…
20a3d4a 
…al completeness.
mcarare added a commit that referenced this issue May 24, 2021
@mcarare
For #17538: Perform autofill storage warm-up after visual completeness.
9400f58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
cc-autofill Autofill credit card E1 Estimation Point: trivial, less than half day Feature:Autofill Address and Credit Card autofill
Projects
None yet
Milestone
90
Development

Successfully merging a pull request may close this issue.

For #17538: Perform autofill storage warm-up after visual completeness. mcarare/fenix
5 participants
@kbrosnan @grigoryk @gabrielluong @mcarare @amedyne