Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Website scrolled up when returning from fullscreen video with dynamic top toolbar #17899

Closed
Mugurell opened this issue Feb 8, 2021 · 2 comments
Closed

[Bug] Website scrolled up when returning from fullscreen video with dynamic top toolbar #17899

Mugurell opened this issue Feb 8, 2021 · 2 comments
Assignees
@Mugurell
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Media Feature:Toolbar Address bar, see also Feature:Search
Milestone
87

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Feb 8, 2021 •
edited by data-sync-user
Loading

Steps to reproduce

  • Have the toolbar set at dynamic and set to be on top, fully expanded
  • Access a website which allows playing videos in fullscreen
  • Enter fullscreen
  • Exit fullscreen

Expected behavior

  • The website shows the same as before entering fullscreen

Actual behavior

  • The website is scrolled to the top (with probably the size if the toolbar)

Build info

Today's Nightly.
Possibly a regression from #10686

┆Issue is synchronized with this Jira Task
@Mugurell Mugurell added 🐞 bug Crashes, Something isn't working, .. Feature:Toolbar Address bar, see also Feature:Search Feature:Media labels Feb 8, 2021
@Mugurell Mugurell self-assigned this Feb 8, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 8, 2021
@Mugurell Mugurell removed the needs:triage Issue needs triage label Feb 9, 2021
@Mugurell
Copy link
Contributor Author

Mugurell commented Feb 9, 2021

The issue seems to happen only when pressing the back button to exit fullscreen, and even then not all the time.
Seems like upon showing again the toolbar the custom behavior that should place the browser immediately below the toolbar doesn't have it's onDependentViewChanged method called and so it remains expanded to fill the screen like we previously set when entering fullscreen.

@Mugurell Mugurell mentioned this issue Feb 9, 2021
Closed
@Mugurell Mugurell mentioned this issue Feb 11, 2021
Closed
Mugurell added a commit that referenced this issue Feb 19, 2021
@Mugurell
For #17899 - Expand toolbar when returning from fullscreen video
6e0a648 
This was the previous behavior for both the top and bottom toolbars.
Regressed when changing to use a new custom behavior for the top toolbar.

When entering fullscreen we will now collapse and hide the toolbar, allow the
browser to expand to the entire screen estate and then, when exiting fullscreen
expand the toolbar.
Collapsing and then expanding the toolbar will trigger the
EngineViewBrowserToolbarBehavior to place the browser below the toolbar.
@Mugurell Mugurell added the eng:qa:needed QA Needed label Feb 23, 2021
@lobontiumira
Copy link

I was not able to reproduce this issue on 2/23 Nightly build, on Beta 87.0.0-beta.1, nor on RC 86.1.1.
I've tested with Google Pixel (Android 10), and with sony Xperia Z5 Premium (Android 7.1.1).
After exiting the fullscreen mode via the back button, the website isn't scrolled to the top.

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Feb 24, 2021
@amedyne amedyne modified the milestones: 88, 87 Feb 26, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
@Mugurell @pkirakosyan
For mozilla-mobile#17899 - Expand toolbar when returning from fullscr…
1e8d5a7 
…een video

This was the previous behavior for both the top and bottom toolbars.
Regressed when changing to use a new custom behavior for the top toolbar.

When entering fullscreen we will now collapse and hide the toolbar, allow the
browser to expand to the entire screen estate and then, when exiting fullscreen
expand the toolbar.
Collapsing and then expanding the toolbar will trigger the
EngineViewBrowserToolbarBehavior to place the browser below the toolbar.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Media Feature:Toolbar Address bar, see also Feature:Search
Projects
None yet
Milestone
87
Development

No branches or pull requests
3 participants
@Mugurell @lobontiumira @amedyne