Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Add telemetry probes for HomeActivity.onCreate and FenixApplication.onCreate #17969

Closed
mcomella opened this issue Feb 11, 2021 · 3 comments
Closed

Add telemetry probes for HomeActivity.onCreate and FenixApplication.onCreate #17969

mcomella opened this issue Feb 11, 2021 · 3 comments
Assignees
@mcomella
Labels
eng:qa:not-needed Added by QA to issues that cannot be tested needs:triage Issue needs triage performance Possible performance wins

Comments

@mcomella
Copy link
Contributor

mcomella commented Feb 11, 2021 •
edited by data-sync-user
Loading

Currently, we have startup probe with a complex implementation and that is complex to analyze: app_opened_all_startup. I wonder if we can't glean some insights more quickly (both knowing the implementation is correct and that it's simple to analyze – e.g. pops out in GLAM) if we instrumented smaller parts of start up. Let's start with two areas that run frequently and don't have significant conditions around them (e.g. onStart being called on startup and for foregrounding the app).

┆Issue is synchronized with this Jira Task
@mcomella mcomella added the performance Possible performance wins label Feb 11, 2021
@mcomella mcomella self-assigned this Feb 11, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 11, 2021
@mcomella
Copy link
Contributor Author

MarcLeclair pointed out that HomeActivity may not be so simple: on COLD start, we may initialize additional components lazily and be running additional initialization in the background (e.g. Gecko start up). Let's land it anyway and see if we find a standard deviation in the results.

mcomella added a commit to mcomella/fenix that referenced this issue Feb 11, 2021
@mcomella
For mozilla-mobile#17969: add duration probes for App.onCreate and Ho…
1879ff6 
…meActivity.onCreate.
@mcomella mcomella mentioned this issue Feb 11, 2021
Merged
3 tasks
mcomella added a commit to mcomella/fenix that referenced this issue Feb 11, 2021
@mcomella
For mozilla-mobile#17969: add duration probes for App.onCreate and Ho…
0d14f1d 
…meActivity.onCreate.
@mcomella
Copy link
Contributor Author

PR: #17973 (comment)

mcomella added a commit that referenced this issue Feb 19, 2021
@mcomella
For #17969: add duration probes for App.onCreate and HomeActivity.onC…
993428c 
…reate.
@mcomella
Copy link
Contributor Author

Completed in 993428c

@mcomella mcomella added the eng:qa:not-needed Added by QA to issues that cannot be tested label Feb 19, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
@mcomella @pkirakosyan
For mozilla-mobile#17969: add duration probes for App.onCreate and Ho…
f422b72 
…meActivity.onCreate.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcomella mcomella

Labels
eng:qa:not-needed Added by QA to issues that cannot be tested needs:triage Issue needs triage performance Possible performance wins
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mcomella