Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Find in Page covers geckoview web content #18122

Closed
codrut-topliceanu opened this issue Feb 23, 2021 · 3 comments
Closed

[Bug] Find in Page covers geckoview web content #18122

codrut-topliceanu opened this issue Feb 23, 2021 · 3 comments
Assignees
@Mugurell
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:FindBar Feature:Toolbar Address bar, see also Feature:Search qa-triaged Issues triaged by qa
Milestone
89

Comments

@codrut-topliceanu
Copy link
Contributor

codrut-topliceanu commented Feb 23, 2021 •
edited by data-sync-user
Loading

Steps to reproduce

  • Preconditions: Open Fenix Settings -> Customize; set Toolbar TOP, set Scroll to hide toolbar to OFF
  • Open new tab and navigate to wikipedia.org
  • Scroll to bottom of the page ( you can clearly see "Terms of Use", "Privacy Policy", etc)
  • Click 3 dot menu and select Find in Page
  • Type "Terms of Use"
  • Press back to hide keyboard

Expected behavior

  • Found text/bottom of the page should be visible

Actual behavior

  • Find in Page editText box coves the lower part of the geckoview obscuring the found "Terms of Use" text. Cannot scroll down further to bring "Terms of Use" into view

Device information

  • Device vendor / model and Android version: Pixel 3XL(Android 10), Pixel 4 (Android 11)
  • Firefox for Android version: current master, and Nightly 2100222

Also of note: Top toolbar is missing.

┆Issue is synchronized with this Jira Task
@codrut-topliceanu codrut-topliceanu added the 🐞 bug Crashes, Something isn't working, .. label Feb 23, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 23, 2021
@codrut-topliceanu codrut-topliceanu added Feature:FindBar Feature:Toolbar Address bar, see also Feature:Search labels Feb 23, 2021
@codrut-topliceanu codrut-topliceanu mentioned this issue Feb 23, 2021
Closed
@test491
Copy link

test491 commented Feb 25, 2021

reproducible also on

  • version: 87.0.0-beta.1 (Build #2015795065) AC: 73.0.0, 69a800e47 GV: 87.0-20210222154334 AS: 71.0.0

android 9, Galaxy J7 Nxt

@LaurentiuApahideanSV
Copy link

I can confirm the issue is reproducible on Firefox Preview 86.1.1, 87.0.0-beta.2 and Nightly 210304.

Devices used:

  • OnePlus 6T (Android 9)
  • Google Pixel 3 XL (Android 9)

@LaurentiuApahideanSV LaurentiuApahideanSV added qa-triaged Issues triaged by qa and removed needs:triage Issue needs triage labels Mar 4, 2021
mcarare pushed a commit that referenced this issue Apr 9, 2021
@Mugurell @mcarare
For #18122 - Update browser layout for find in page bar with bottom t…
660f060 
…oolbar

With a dynamic bottom toolbar the  browser extends all the way to the bottom of
the screen and so when the find in page bar is shown it will be so above the
bottom part of the browser which may contain exactly the searched for items.

To fix the browser must effectively be placed at the top of the newly shown
find in page bar.
@Mugurell Mugurell added this to the 89 milestone Apr 9, 2021
@Mugurell Mugurell added the eng:qa:needed QA Needed label Apr 9, 2021
@Mugurell Mugurell self-assigned this Apr 9, 2021
@ebalazs-sv
Copy link

Verified as fixed on Nightly 4/13 with Samsung Galaxy Tab S3 (Android 8).
The "Terms of Use" is visible when the keyboard is hidden.

@ebalazs-sv ebalazs-sv added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Apr 13, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 8, 2021
@Mugurell @pkirakosyan
For mozilla-mobile#18122 - Update browser layout for find in page bar…
ee20654 
… with bottom toolbar

With a dynamic bottom toolbar the  browser extends all the way to the bottom of
the screen and so when the find in page bar is shown it will be so above the
bottom part of the browser which may contain exactly the searched for items.

To fix the browser must effectively be placed at the top of the newly shown
find in page bar.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:FindBar Feature:Toolbar Address bar, see also Feature:Search qa-triaged Issues triaged by qa
Projects
None yet
Milestone
89
Development

No branches or pull requests
5 participants
@Mugurell @ebalazs-sv @LaurentiuApahideanSV @codrut-topliceanu @test491