Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Rework History Telemetry #18178

Closed
rocketsroger opened this issue Feb 25, 2021 · 2 comments · Fixed by #18261
Closed

Rework History Telemetry #18178

rocketsroger opened this issue Feb 25, 2021 · 2 comments · Fixed by #18261
Assignees
Milestone

Comments

@rocketsroger
Copy link
Contributor

rocketsroger commented Feb 25, 2021

Currently anytime a user uses the History to open a tab we record the same telemetry. The problem with this is that we can't distinguish between the user tapping on history, tapping 3 dot menu to open in new tab, tapping 3 dot menu to open in private tab, select multiple to open in new tab or select multiple to open in private tab.

Rework history telemetry so we can distinguish between all 5 cases.

┆Issue is synchronized with this Jira Task

@rocketsroger rocketsroger self-assigned this Feb 25, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 25, 2021
@rocketsroger rocketsroger removed the needs:triage Issue needs triage label Feb 25, 2021
@rocketsroger
Copy link
Contributor Author

For #14866

rocketsroger added a commit to rocketsroger/fenix that referenced this issue Mar 2, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Mar 2, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Mar 8, 2021
@gabrielluong gabrielluong added the eng:qa:needed QA Needed label Mar 9, 2021
@gabrielluong gabrielluong reopened this Mar 9, 2021
@gabrielluong gabrielluong added this to the 88 milestone Mar 9, 2021
@lobontiumira
Copy link

lobontiumira commented Mar 15, 2021

Verified on the 3/15 Nightly build with Google Pixel (Android 10):

  • ping a2e62209-bef0-4223-83fa-cd528577f448
  • opened_item_in_new_tab:
{
          "category": "history",
          "name": "opened_item_in_new_tab",
          "timestamp": 25915
        }
  • opened_items_in_new_tabs:
 {
          "category": "history",
          "name": "opened_items_in_new_tabs",
          "timestamp": 10537
        }
  • opened_item_in_private_tab:
{
          "category": "history",
          "name": "opened_item_in_private_tab",
          "timestamp": 33429
        }
  • opened_items_in_private_tabs:
{
          "category": "history",
          "name": "opened_items_in_private_tabs",
          "timestamp": 17996
        }

logcat.txt

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants