-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Add card] Integrate the credit card provider validation to validate the card number #18266
Comments
Since we added some basic credit card validation with the Luhn algorithm in #19065, let's go ahead with adding the form input validation. We will eventually refactor some of the credit card validation to be able to determine the credit card type from mozilla-mobile/android-components#9813. In the meantime, we can use |
@gabrielluong Is there a Figma link or on another platform for the designs? Thank you! |
Tested on Nightly 5/7 with Samsung Note 10 (Android 10) and here are the results:
I will remove the qa label until the feedback is received. |
@sflorean This is not related to card validation, but to the way a saved card is displayed. I would open that in a separate issue to track the changes needed. Thank you for testing! |
Thank you @mcarare I will open a new issue. |
I added the issues that were discussed above, you can find it here #19482. |
When mozilla-mobile/android-components#9813 lands, we should ensure we are validating the card number in the "Add card" screen.
This depends on #18243 and mozilla-mobile/android-components#9813.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: