Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Add card] Integrate the credit card provider validation to validate the card number #18266

Closed
gabrielluong opened this issue Mar 2, 2021 · 6 comments · Fixed by #19267
Closed
Assignees
Labels
cc-autofill Autofill credit card E2 Estimation Point: easy, half a day to 2 days eng:qa:verified QA Verified Feature:Autofill Address and Credit Card autofill
Milestone

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Mar 2, 2021

When mozilla-mobile/android-components#9813 lands, we should ensure we are validating the card number in the "Add card" screen.

This depends on #18243 and mozilla-mobile/android-components#9813.

Screen Shot 2021-03-02 at 4 14 41 PM

┆Issue is synchronized with this Jira Task

@gabrielluong gabrielluong added blocked Feature:Autofill Address and Credit Card autofill cc-autofill Autofill credit card labels Mar 2, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 2, 2021
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Mar 2, 2021
@gabrielluong gabrielluong changed the title Integrate the credit card provider validation to validate the card number [Credit cards] Integrate the credit card provider validation to validate the card number Mar 2, 2021
@gabrielluong gabrielluong changed the title [Credit cards] Integrate the credit card provider validation to validate the card number [Add card] Integrate the credit card provider validation to validate the card number Mar 2, 2021
@gabrielluong gabrielluong added the E2 Estimation Point: easy, half a day to 2 days label Mar 2, 2021
@gabrielluong
Copy link
Member Author

Since we added some basic credit card validation with the Luhn algorithm in #19065, let's go ahead with adding the form input validation. We will eventually refactor some of the credit card validation to be able to determine the credit card type from mozilla-mobile/android-components#9813. In the meantime, we can use validateCreditCardNumber that was added.

@mcarare mcarare self-assigned this Apr 27, 2021
@mcarare
Copy link
Contributor

mcarare commented Apr 27, 2021

@gabrielluong Is there a Figma link or on another platform for the designs? Thank you!

mcarare added a commit to mcarare/fenix that referenced this issue Apr 27, 2021
mcarare added a commit to mcarare/fenix that referenced this issue Apr 27, 2021
mcarare added a commit to mcarare/fenix that referenced this issue Apr 27, 2021
mcarare added a commit to mcarare/fenix that referenced this issue Apr 27, 2021
mcarare added a commit to mcarare/fenix that referenced this issue Apr 27, 2021
mcarare added a commit to mcarare/fenix that referenced this issue Apr 28, 2021
mcarare added a commit to mcarare/fenix that referenced this issue Apr 28, 2021
mcarare added a commit to mcarare/fenix that referenced this issue Apr 28, 2021
@gabrielluong gabrielluong added this to the 90 milestone May 4, 2021
mcarare added a commit to mcarare/fenix that referenced this issue May 5, 2021
mcarare added a commit to mcarare/fenix that referenced this issue May 6, 2021
@gabrielluong gabrielluong reopened this May 6, 2021
@gabrielluong gabrielluong added the eng:qa:needed QA Needed label May 6, 2021
@sflorean
Copy link
Contributor

sflorean commented May 7, 2021

Tested on Nightly 5/7 with Samsung Note 10 (Android 10) and here are the results:

  • couldn't add an invalid card
  • it doesn't matter if the card's information aren't correct (name, date), the card was added
  • here is a screenshot of the added card

cc @gabrielluong @mcarare

I will remove the qa label until the feedback is received.

@sflorean sflorean removed the eng:qa:needed QA Needed label May 7, 2021
@mcarare
Copy link
Contributor

mcarare commented May 11, 2021

@sflorean This is not related to card validation, but to the way a saved card is displayed. I would open that in a separate issue to track the changes needed. Thank you for testing!

@sflorean
Copy link
Contributor

Thank you @mcarare I will open a new issue.

@sflorean sflorean added the eng:qa:verified QA Verified label May 12, 2021
@abodea
Copy link
Member

abodea commented May 12, 2021

I added the issues that were discussed above, you can find it here #19482.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cc-autofill Autofill credit card E2 Estimation Point: easy, half a day to 2 days eng:qa:verified QA Verified Feature:Autofill Address and Credit Card autofill
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants