Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Telemetry] Recently closed tabs #21009

Closed
1 of 7 tasks
Mugurell opened this issue Aug 25, 2021 · 3 comments
Closed
1 of 7 tasks

[Telemetry] Recently closed tabs #21009

Mugurell opened this issue Aug 25, 2021 · 3 comments
Assignees
@Mugurell
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:InactiveTabs Tabs in the tabs tray that have not been used in some time. Feature:Telemetry

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Aug 25, 2021 •
edited by data-sync-user
Loading

Description & Product Manager / Data Scientist User Story

As a Product Manager, I want to collect telemetry data on user interactions in the "Recently closed tabs" screen.

What questions will you answer with this data?

  • When user opens this screen
  • When user closes this screen
  • When "Show full history" is tapped
  • All interactions with the tabs listed here. Similar to what's being tracked for the "History" screen.

(#20508 used the same tabs_tray.opened_existing_tab and tabs_tray.opened_existing_tab events for the tabs shown in the "Inactive tabs" section but with different "source" extra keys to make the lineage clearer. Opening or closing a tab on this screen, if being opened from the tabs tray should use a similar approach).

Acceptance Criteria

  • ENG files a DS JIRA request outlining their methodology - https://mozilla-hub.atlassian.net/browse/DS-1727
  • DS sign off on instrumentation methodology addressing product questions.
  • Event pings can be queried via re:dash
  • Event pings can be queried via amplitude
  • We are sending telemetry events for the actions listed in the requirements
  • We have documented the telemetry
  • We have asked a data steward to review the telemetry

Events to add in a new recently_closed_tabs category:

  • opened - User opened the "Recently closed tabs" screen.
  • closed - User closed the "Recently closed tabs" screen.
  • show_full_history - User tapped "Show full history" to see all history.
  • open_tab - User tapped on a tab item to be opened.
  • delete_tab - User tapped the delete button of a tab item.
  • menu_close - User tapped the close button - "X" to return to the previous screen.
  • menu_share - User tapped the share menu option for multi selected tabs.
  • menu_delete - User tapped the delete menu option for multi selected tabs.
  • menu_open_in_normal_tab - User tapped the "Open in new tab" menu option for multi selected tabs.
  • menu_open_in_private_tab - User tapped the "Open in private tab" menu option for multi selected tabs.
  • enter_multiselect - User tapped on a tab item to enter multi select mode.
  • exit_multiselect - User pressed back or tapped the last selected tab item to exit multiselect.

(More probes were initially proposed but #20893 removed some of the options for individual tab items in the meantime)

┆Issue is synchronized with this Jira Task
@github-actions github-actions bot added the needs:triage Issue needs triage label Aug 25, 2021
@amedyne amedyne added Feature:InactiveTabs Tabs in the tabs tray that have not been used in some time. Feature:Telemetry and removed needs:triage Issue needs triage labels Aug 26, 2021
@Mugurell Mugurell added the E3 Estimation Point: average, 2 - 3 days label Aug 30, 2021
@Mugurell Mugurell self-assigned this Aug 31, 2021
@Mugurell Mugurell added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Sep 3, 2021
@Mugurell
Copy link
Contributor Author

Mugurell commented Sep 3, 2021

Waiting for DS recommendations regarding the proposed probes - https://mozilla-hub.atlassian.net/browse/DS-1727.

@Mugurell Mugurell mentioned this issue Nov 26, 2021
Merged
3 tasks
mergify bot pushed a commit that referenced this issue Feb 3, 2022
@Mugurell @mergify
For #21009 - New Recently closed tabs telemetry
0be470a 
This adds a new `recently_closed_tabs` category with then events for all user
interactions on the screen.

The already existent `events.recently_closed_tabs_opened` is still kept for a
bit more time to still have this data available while the new telemetry ride
the trains but can later be removed in favor of this newly added events.
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 10, 2022
@Mugurell @pkirakosyan
For mozilla-mobile#21009 - New Recently closed tabs telemetry
5e174c8 
This adds a new `recently_closed_tabs` category with then events for all user
interactions on the screen.

The already existent `events.recently_closed_tabs_opened` is still kept for a
bit more time to still have this data available while the new telemetry ride
the trains but can later be removed in favor of this newly added events.
@Mugurell
Copy link
Contributor Author

This landed in #22588 which also contain more details about the new probes.

@Mugurell Mugurell added eng:qa:needed QA Needed and removed 🙅 waiting Issues that are blocked or has dependencies that are not ready labels May 26, 2022
@Mugurell
Copy link
Contributor Author

Saw this was verified indirectly when the telemetry migration was verified - #24210 (comment)
Closing as verified.

@Mugurell Mugurell added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:InactiveTabs Tabs in the tabs tray that have not been used in some time. Feature:Telemetry
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mugurell @amedyne