Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Reduce redirection of colors variables between dark and light theme #21973

Closed
gabrielluong opened this issue Oct 16, 2021 · 4 comments
Closed

Reduce redirection of colors variables between dark and light theme #21973

gabrielluong opened this issue Oct 16, 2021 · 4 comments
Assignees
@gabrielluong
Labels
eng:qa:verified QA Verified Feature:Themes Dark mode, light mode, private browsing mode
Milestone
96

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Oct 16, 2021 •
edited by data-sync-user
Loading

Continuation of #21935, we will look at reducing the amount of redirection between variables between dark and light theme.

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong self-assigned this Oct 16, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 16, 2021
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Oct 16, 2021
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Use destructive_normal_theme in place of R…
ef63ef8 
….color.design_color
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Remove @color/sescondary_text_dark_theme r…
8a7686b 
…edirection
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Remove @color/contrast_text_dark_theme red…
73b4c2d 
…irection
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Remove @color/caption_text_dark_theme redi…
c8377cb 
…rection
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Remove redirection of color variables for …
26a77b5 
…the tabs tray color variables
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Remove redirection of color variables for …
ee73bdc 
…the collection color variables
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Remove @color/toggle_off_knob_light_theme …
96d976c 
…and @color/toggle_off_track_light_theme redirection
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Remove @color/synced_tabs_separator_dark_t…
b5f0507 
…heme redirection
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Remove @color/top_site_title_text_dark_the…
0d1cb99 
…me redirection
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Remove @color/inset_dark_theme redirection
ce89289
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Remove @color/top_site_title_text_light_th…
ee3437e 
…eme redirection
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Remove @color/secondary_text_light_theme r…
3c2b19b 
…edirection
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Remove @color/caption_text_light_theme red…
34f5df9 
…irection
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Remove @color/above_light_theme redirection
b7b3ad8
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Remove @color/about_link_dark_theme redire…
865de88 
…ction
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Remove @color/accent_high_contrast_light_t…
256d282 
…heme redirection
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Remove @color/tab_ring_light_theme redirec…
9841877 
…tion
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Remove @color/neutral_light_theme redirection
03b6eed
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Remove @color/neutral_faded_light_theme re…
7f4f82e 
…direction
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Remove @color/shadow_light_theme redirection
2fce2e9
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Remove @color/destructive_light_theme redi…
8eba652 
…rection
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Remove @color/disabled_light_theme redirec…
b054388 
…tion
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Remove @color/scrimStart_light_theme redir…
0d13530 
…ection
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Remove @color/scrimEnd_light_theme reddire…
1b1f080 
…ction
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 21, 2021
@gabrielluong
For mozilla-mobile#21973 - Remove @color/synced_tabs_separator_light_…
cd54084 
…theme redirection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/neutral_dark_theme redirection
1a76c11
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/neutral_faded_dark_theme red…
5c7479f 
…irection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/shadow_dark_theme redirection
2c512ac
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/disabled_dark_theme redirection
3696604
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/onboarding_card_background_[…
a4fe459 
…start|end]_gradient_dark_theme redirection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/onboarding_illustration_sele…
fd8dde2 
…cted_dark_theme redirection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/swipe_delete_background_dark…
73ecd87 
…_theme redirection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/toolbar_divider_color_dark_t…
a3edcd4 
…heme redirection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/toolbar_[start|center|end]_g…
608b078 
…radient_dark_theme redirection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/sync_disconnected_icon_fill_…
37b27c4 
…dark_theme redirection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/sync_disconnected_background…
bb80c0c 
…_dark_theme redirection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/add_on_private_browsing_exte…
7c9a3b8 
…rior_circle_background_dark_theme redirection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/add_on_private_browsing_inte…
2e39e8a 
…rior_icon_background_dark_theme redirection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/prompt_login_edit_text_curso…
8d3d0bb 
…r_color_dark_theme redirection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/preference_section_header_da…
ff2f139 
…rk_theme redirection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/search_suggestion_indicator_…
eff347c 
…icon_bookmark_color_dark_theme redirection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/onboarding_illustration_dese…
f7e9da7 
…lected_dark_theme redirection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/tab_tray_item_text_dark_them…
b9c7060 
…e redirection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/tab_tray_item_url_dark_theme…
f9edb87 
… redirection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/tab_tray_item_background_dar…
467b301 
…k_theme redirection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/tab_tray_toolbar_background_…
6120663 
…dark_theme redirection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/tab_tray_item_divider_dark_t…
1a3b1e7 
…heme redirection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/tab_tray_item_media_backgrou…
8886660 
…nd_dark_them redirection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/tab_tray_heading_icon_menu_d…
506924c 
…ark_theme redirection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/tab_tray_item_thumbnail_back…
74ebf96 
…ground_dark_theme redirection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/tab_tray_item_thumbnail_icon…
d50cf5a 
…_dark_theme redirection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/tab_tray_selected_mask_dark_…
77a427e 
…theme redirection
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/foundation_dark_theme redire…
53df361 
…ction
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/accent_dark_theme redirection
3efafce
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#21973 - Remove @color/search_suggestion_indicator_…
542ce22 
…icon_color_dark_theme redirection
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

Labels
eng:qa:verified QA Verified Feature:Themes Dark mode, light mode, private browsing mode
Projects
None yet
Milestone
96
Development

Successfully merging a pull request may close this issue.

For #21973 - Reduce redirection of colors variables between dark and light theme gabrielluong/fenix
2 participants
@gabrielluong @LaurentiuApahideanSV