Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

Crash when opening opening a history group #22226

Closed
Mugurell opened this issue Oct 29, 2021 · 1 comment
Closed

Crash when opening opening a history group #22226

Mugurell opened this issue Oct 29, 2021 · 1 comment
Assignees
Labels
eng:qa:verified QA Verified Feature:History Feature:SearchGroupHistory Search term groups on History view
Milestone

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Oct 29, 2021

We show the the same menu options for individual history items and for the new history groups.
When selecting the option to "Option in new tab" for a history group the app will crash with the following stacktrace

java.lang.ClassCastException: org.mozilla.fenix.library.history.History$Group cannot be cast to org.mozilla.fenix.library.history.History$Regular
    at org.mozilla.fenix.library.history.HistoryFragment$onOptionsItemSelected$2.invoke(HistoryFragment.kt:212)
    at org.mozilla.fenix.library.history.HistoryFragment$onOptionsItemSelected$2.invoke(HistoryFragment.kt:211)
    at kotlin.sequences.TransformingSequence$iterator$1.next(Sequences.kt:210)
    at kotlin.sequences.FilteringSequence$iterator$1.calcNext(Sequences.kt:170)
    at kotlin.sequences.FilteringSequence$iterator$1.hasNext(Sequences.kt:194)
    at org.mozilla.fenix.library.LibraryPageFragment.openItemsInNewTab(LibraryPageFragment.kt:1290)
    at org.mozilla.fenix.library.LibraryPageFragment.openItemsInNewTab$default(LibraryPageFragment.kt:27)
    at org.mozilla.fenix.library.history.HistoryFragment.onOptionsItemSelected(HistoryFragment.kt:211)

 

Sentry issue - https://sentry.prod.mozaws.net/operations/firefox-nightly/issues/13630000/events/79218836/

 

CrashWhenOpeningAHistoryGroup.mp4

┆Issue is synchronized with this Jira Task

@Mugurell Mugurell added Feature:History Feature:SearchGroupHistory Search term groups on History view labels Oct 29, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 29, 2021
@Mugurell Mugurell self-assigned this Oct 29, 2021
@Mugurell Mugurell removed the needs:triage Issue needs triage label Oct 29, 2021
@SoftVision-LorandJanos
Copy link

Verified as fixed on the latest Nightly 96.0a1 (2021-11-03T05:10:24.120708) and on the latest Beta (95.0.0-beta.1).

Device used: Xiaomi Mi11 (Android 11).

Closing the ticket as fixed.

mergify bot pushed a commit that referenced this issue Nov 9, 2021
@amedyne amedyne added this to the 95 milestone Nov 16, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:qa:verified QA Verified Feature:History Feature:SearchGroupHistory Search term groups on History view
Projects
None yet
Development

No branches or pull requests

3 participants