Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Replace whats_new_notification_color with fx_mobile_icon_color_notice color token #22701

Closed
gabrielluong opened this issue Dec 4, 2021 · 0 comments · Fixed by #22723
Closed

Replace whats_new_notification_color with fx_mobile_icon_color_notice color token #22701

gabrielluong opened this issue Dec 4, 2021 · 0 comments · Fixed by #22723
Assignees
@gabrielluong
Labels
Feature:Themes Dark mode, light mode, private browsing mode
Milestone
96

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Dec 4, 2021 •
edited by data-sync-user
Loading

We can replace whats_new_notification_color https://searchfox.org/mozilla-mobile/source/fenix/app/src/main/res/values/colors.xml#319 with fx_mobile_icon_color_notice since they are the same color and intended to represent "New"

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong added this to the 96 milestone Dec 4, 2021
@gabrielluong gabrielluong self-assigned this Dec 4, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Dec 4, 2021
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Dec 4, 2021
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Dec 6, 2021
@gabrielluong
For mozilla-mobile#22701 - Replace whats_new_notification_color with …
a2ed7ca 
…fx_mobile_icon_color_notice color token
@gabrielluong gabrielluong mentioned this issue Dec 6, 2021
Merged
3 tasks
@mergify mergify bot closed this as completed in #22723 Dec 6, 2021
mergify bot pushed a commit that referenced this issue Dec 6, 2021
@gabrielluong @mergify
For #22701 - Replace whats_new_notification_color with fx_mobile_icon…
5960727 
…_color_notice color token
@gabrielluong gabrielluong added the Feature:Themes Dark mode, light mode, private browsing mode label Dec 15, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 8, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#22701 - Replace whats_new_notification_color with …
6148bc2 
…fx_mobile_icon_color_notice color token
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

Labels
Feature:Themes Dark mode, light mode, private browsing mode
Projects
None yet
Milestone
96
1 participant
@gabrielluong