Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Remove wrapper for context menu metrics #24206

Closed
mcarare opened this issue Mar 11, 2022 · 3 comments
Closed

Remove wrapper for context menu metrics #24206

mcarare opened this issue Mar 11, 2022 · 3 comments
Assignees
Labels
eng:qa:verified QA Verified Feature:ContextMenu Menu that appears when long-pressing on website content Feature:Telemetry

Comments

@mcarare
Copy link
Contributor

mcarare commented Mar 11, 2022

Breakout from #21292.

┆Issue is synchronized with this Jira Task

@mcarare mcarare added Feature:Telemetry Feature:ContextMenu Menu that appears when long-pressing on website content labels Mar 11, 2022
@mcarare mcarare self-assigned this Mar 11, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 11, 2022
@mcarare mcarare removed the needs:triage Issue needs triage label Mar 11, 2022
@mcarare mcarare added the eng:qa:needed QA Needed label Apr 13, 2022
@delia-pop
Copy link

Verified on the latest Nightly 101.0a1 (2022-04-15) using the following flow:

  • long tap on a linked text/linked image > tap on every option from the context menu;
  • long tap on text > Copy;
  • Paste the copied text in a search bar.

@mcarare These are the only events that were observed by us:

image_2022_04_15T13_41_19_342Z

Device used: Google Pixel 6 (Android 12).

@mcarare
Copy link
Contributor Author

mcarare commented Apr 15, 2022

@delia-pop Thank you for testing!
This should be fixed in the next nightly or current main branch.

@mcarare mcarare added the eng:qa:needed QA Needed label Apr 15, 2022
@sflorean
Copy link
Contributor

Verified as fixed on Nightly 4/ 18 with OnePlus 9 (Android 12). Please check below some of the context menu metrics.

{
          "timestamp": 160654,
          "category": "context_menu",
          "name": "item_tapped",
          "extra": {
            "named": "open_in_new_tab"
          }
          "timestamp": 164063,
          "category": "context_menu",
          "name": "item_tapped",
          "extra": {
            "named": "open_in_private_tab"
          }
          "timestamp": 166847,
          "category": "context_menu",
          "name": "item_tapped",
          "extra": {
            "named": "copy_link"
          }
          "timestamp": 170951,
          "category": "context_menu",
          "name": "item_tapped",
          "extra": {
            "named": "share_link"
          }
          "timestamp": 174533,
          "category": "context_menu",
          "name": "item_tapped",
          "extra": {
            "named": "share_image"
          }
          "timestamp": 177634,
          "category": "context_menu",
          "name": "item_tapped",
          "extra": {
        {
          "timestamp": 181312,
          "category": "context_menu",
          "name": "item_tapped",
          "extra": {
            "named": "save_image"
          }
          "timestamp": 184085,
          "category": "context_menu",
          "name": "item_tapped",
          "extra": {
            "named": "copy_image_location"
          }

@sflorean sflorean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Apr 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:qa:verified QA Verified Feature:ContextMenu Menu that appears when long-pressing on website content Feature:Telemetry
Projects
None yet
Development

No branches or pull requests

3 participants