[Bug] Private mode does not switch anymore

[dholbert]

Steps to reproduce

1. Open a private tab in Fenix, viewing e.g. example.org
2. Tap the tab-switcher icon at bottom right
3. Tap the "x" to close your open tab, so that you're just viewing the home-screen.
   --> Notice the "You're in a private session" paragraph
4. Tap the Private-Browsing-Mask icon at top right of home screen

Expected behavior

As I leave Private Browsing, the "You're in a private session" message should disappear (and probably be replaced by my non-private-browsing tab-stacks)

Actual behavior

The "You're in a private session" message remains, even though I've now left my private session.

Device information

• Android device: Pixel 3
• Fenix version: 1.0.1919

I'm guessing @sblatz might know what to do with this, since he worked on other stuff related to PB homescreen UI e.g. #347.

┆Issue is synchronized with this Jira Task

[dholbert]

Screencast of bug: https://www.dropbox.com/s/gjf8rlgifda2qor/pb-bug.mp4?dl=0

[dholbert]

In general, it looks like the homescreen doesn't change when I switch into/out-of PB mode. (i.e. this bug exists in the opposite direction as well -- for example, when I tap the mask to switch from normal into PB mode, my normal-mode tab-stacks are still visible on the homescreen.)

So that might be the general root issue. But it's particularly problematic for this switching-from-Private-to-normal user flow, because it results in us making a privacy-related declaration that is not actually true ("You're in a private session" etc)

[sblatz]

Thanks for reporting, @dholbert. Looks like an issue that was introduced with ccbc14a.

[LittleAngelwings]

Maybe similar with this issue: #2411

[dholbert]

Yeah -- that other issue describes stale content on the homescreen after swapping from normal to PB mode, vs. this issue here is about stale content on homescreen after swapping from PB to normal mode.

Likely the same underlying problem.

[sblatz]

Closing as dupe of #2411. This is the same root issue caused by our ViewModel changes