Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Add private browsing logic #347

Closed
sblatz opened this issue Feb 1, 2019 · 10 comments
Closed

Add private browsing logic #347

sblatz opened this issue Feb 1, 2019 · 10 comments
Assignees

Comments

@sblatz
Copy link
Contributor

sblatz commented Feb 1, 2019

Parent: #277

  • Add the actual android component for private browsing so switching into the mode actually makes your session private
  • Ensure private browsing is persistent if a user force closes the app but it was last left in private mode, we should start up in private mode

Mock-ups found here

┆Issue is synchronized with this Jira Task

@pocmo
Copy link
Contributor

pocmo commented Feb 1, 2019

There's no component for "private browsing" directly. But when creating a Session you can specify whether it's private or not:
https://github.com/mozilla-mobile/android-components/blob/master/components/browser/session/src/main/java/mozilla/components/browser/session/Session.kt#L26

For situations where you need to pass a "UseCase" to a component you can alternate between AddNewTabUseCase and AddNewPrivateTabUseCase as you see fit.

That's how this looks like in your reference browser:
https://github.com/mozilla-mobile/reference-browser/blob/master/app/src/main/java/org/mozilla/reference/browser/tabs/TabsPanel.kt#L42-L48

If there's something missing or something that could be provided by a component then please let us know :)

@vesta0 vesta0 added needs:ac Needs Android Component Work and removed needs:ac Needs Android Component Work labels Feb 8, 2019
@bbinto bbinto added the size M label Feb 8, 2019
@sblatz sblatz changed the title Integrate a-c for private browsing Add private browsing logic Feb 8, 2019
@sblatz sblatz self-assigned this Feb 11, 2019
@sblatz
Copy link
Contributor Author

sblatz commented Feb 13, 2019

To confirm: this mode will not do any sort of tracking protection / cookie management, and will only stop users history from being stored once the session is complete?

@bbinto

sblatz added a commit to sblatz/fenix that referenced this issue Feb 13, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Feb 13, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Feb 13, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Feb 13, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Feb 13, 2019
@sblatz
Copy link
Contributor Author

sblatz commented Feb 14, 2019

Note: private mode should trigger gboard private mode

@sblatz
Copy link
Contributor Author

sblatz commented Feb 14, 2019

Do we have a specific link we want to use for "common myths about private browsing"?

@jonisavage

sblatz added a commit to sblatz/fenix that referenced this issue Feb 14, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Feb 14, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Feb 14, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Feb 14, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Feb 14, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Feb 14, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Feb 14, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Feb 14, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Feb 14, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Feb 14, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Feb 14, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Feb 14, 2019
@ghost ghost added in progress labels Feb 14, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Feb 14, 2019
@sblatz
Copy link
Contributor Author

sblatz commented Feb 14, 2019

@pocmo do we have the ability to set imeOptions on the AwesomeBar component from Fenix? I'd like to dynamically set flagNoPersonalizedLearning on the editText.

@pocmo
Copy link
Contributor

pocmo commented Feb 14, 2019

@sblatz Not yet. I'll file something for that.

@sblatz
Copy link
Contributor Author

sblatz commented Feb 14, 2019

@pocmo Great, thank you!

@bbinto
Copy link
Contributor

bbinto commented Feb 14, 2019

To confirm: this mode will not do any sort of tracking protection / cookie management, and will only > stop users history from being stored once the session is complete?

@sblatz

We should not divert from the PB mode implementation in our other apps (feature parity): it should be PB with TP on by default.

@jonichan
Copy link

jonichan commented Feb 14, 2019

@sblatz here's a link you can use: https://support.mozilla.org/1/mobile/%VERSION%/%OS%/%LOCALE%/myths-private-browsing

Edit: Please ignore the link above. Michelle already posted the link in another issue. It will point to the same article.

@sblatz
Copy link
Contributor Author

sblatz commented Feb 15, 2019

I believe tracking protection will land with this ticket: #97, and is not in the scope of this one.

@sblatz sblatz closed this as completed in e5fe80f Feb 15, 2019
@ghost ghost removed in progress labels Feb 15, 2019
@data-sync-user data-sync-user changed the title Add private browsing logic FNX3-17037 ⁃ Add private browsing logic Aug 11, 2020
@pocmo pocmo closed this as completed Aug 12, 2020
@data-sync-user data-sync-user changed the title FNX3-17037 ⁃ Add private browsing logic Add private browsing logic May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants