Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Replace Mockito mocks with Mockk mocks #24703

Closed
Mugurell opened this issue Apr 11, 2022 · 1 comment
Closed

Replace Mockito mocks with Mockk mocks #24703

Mugurell opened this issue Apr 11, 2022 · 1 comment
Assignees
@Alexandru2909
Labels
eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer eng:qa:not-needed Added by QA to issues that cannot be tested eng:tech-debt Engineering debt. Missing unit tests, etc. eng:test-debt Test debt. Unit test creation or maintenance. good first issue Good for newcomers help wanted Help wanted from a contributor. More complex than good first issue. needs:triage Issue needs triage

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Apr 11, 2022 •
edited by data-sync-user
Loading

There are placed in our unit tests where Mockito mocks are used and this is causing intermittent test fails.

Saw this issue and fixed two cases on #24620, today I saw another occurrence for another PR.

We'll need to search for all places where mock is used and replace it with mockk.
Special care is needed for deciding where to use a relaxed mockk or not. (behavior is different between Mockito and Mockk)

┆Issue is synchronized with this Jira Task
@Mugurell Mugurell added good first issue Good for newcomers help wanted Help wanted from a contributor. More complex than good first issue. eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer eng:tech-debt Engineering debt. Missing unit tests, etc. eng:test-debt Test debt. Unit test creation or maintenance. labels Apr 11, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 11, 2022
@Alexandru2909 Alexandru2909 self-assigned this Apr 11, 2022
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Apr 11, 2022
For mozilla-mobile#24703 - Replace Mockito mocks with Mockk mocks
2c4eb3d
mergify bot pushed a commit that referenced this issue Apr 11, 2022
@mergify
For #24703 - Replace Mockito mocks with Mockk mocks
08ce8fb
@Alexandru2909 Alexandru2909 added the eng:qa:needed QA Needed label Apr 18, 2022
@Alexandru2909
Copy link
Contributor

Nothing to test for QA, issue deals with unit tests.

@Alexandru2909 Alexandru2909 added eng:qa:not-needed Added by QA to issues that cannot be tested and removed eng:qa:needed QA Needed labels Apr 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Alexandru2909 Alexandru2909

Labels
eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer eng:qa:not-needed Added by QA to issues that cannot be tested eng:tech-debt Engineering debt. Missing unit tests, etc. eng:test-debt Test debt. Unit test creation or maintenance. good first issue Good for newcomers help wanted Help wanted from a contributor. More complex than good first issue. needs:triage Issue needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mugurell @Alexandru2909