Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Telemetry: Open History Item #26502

Closed
mavduevskiy opened this issue Aug 17, 2022 · 1 comment · Fixed by #26503, #26863 or nathanmkaya/fenix#108
Closed

Telemetry: Open History Item #26502

mavduevskiy opened this issue Aug 17, 2022 · 1 comment · Fixed by #26503, #26863 or nathanmkaya/fenix#108
Assignees
Labels
eng:qa:verified QA Verified eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged
Milestone

Comments

@mavduevskiy
Copy link
Contributor

mavduevskiy commented Aug 17, 2022

Questions to answer:

  • How often is a local history item opened
  • How often is a synced history item opened

Proposed metrics:

  • Add a label to the existing history.open_item that identifies what type of history item it was

┆Issue is synchronized with this Jira Task

@mavduevskiy mavduevskiy self-assigned this Aug 17, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Aug 17, 2022
@mavduevskiy mavduevskiy removed the needs:triage Issue needs triage label Aug 17, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Aug 17, 2022
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Aug 17, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Aug 17, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Aug 18, 2022
…iption, format the params, add pull request url and my email
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Aug 18, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Aug 18, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Aug 18, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Aug 18, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Aug 18, 2022
@mergify mergify bot closed this as completed in #26503 Aug 18, 2022
@github-actions github-actions bot added this to the 105 milestone Aug 18, 2022
@github-actions github-actions bot reopened this Aug 18, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Aug 18, 2022
@LaurentiuApahideanSV
Copy link

I tested the issue on Firefox Nightly 105.0a1 2022-08-21 by opening local and synced history items and observing the result.
When a local history website is accessed
{
"timestamp": 35426,
"category": "history",
"name": "opened_item",
"extra": {
"is_remote": "false"
}
When a synced history website is accessed
{
"timestamp": 11760,
"category": "history",
"name": "opened_item",
"extra": {
"is_remote": "true"
}

Device used:

-OnePlus 6T (Android 9)

@LaurentiuApahideanSV LaurentiuApahideanSV added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Aug 22, 2022
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Sep 7, 2022
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Sep 7, 2022
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Sep 7, 2022
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.