Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Create a simple wallpaper dialog #26750

Closed
mavduevskiy opened this issue Sep 1, 2022 · 1 comment · Fixed by #26758, fork-house/fenix#13, #26944 or nathanmkaya/fenix#108
Closed

Create a simple wallpaper dialog #26750

mavduevskiy opened this issue Sep 1, 2022 · 1 comment · Fixed by #26758, fork-house/fenix#13, #26944 or nathanmkaya/fenix#108
Assignees
@mavduevskiy
Labels
eng:qa:verified QA Verified
Milestone
106

Comments

@mavduevskiy
Copy link
Contributor

mavduevskiy commented Sep 1, 2022 •
edited by data-sync-user
Loading

Breaking down this task, while the different dependencies are being cleared up.

Create a wallpaper selector, that follows these conditions:

  •     Tab Pickup and Jump Back In CFRs are not currently being displayed

  •     The user has not seen the wallpaper selection tool before

┆Issue is synchronized with this Jira Task
@mavduevskiy mavduevskiy self-assigned this Sep 1, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 1, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 1, 2022
Closes mozilla-mobile#26750: add Wallpapers Onboarding dialog
cca225c
@mavduevskiy mavduevskiy mentioned this issue Sep 1, 2022
Closed
4 tasks
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Sep 1, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 1, 2022
Closes mozilla-mobile#26750: add Wallpapers Onboarding dialog
2b281f8
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 1, 2022
Closes mozilla-mobile#26750: add Wallpapers Onboarding dialog
df9c04f
@mavduevskiy mavduevskiy mentioned this issue Sep 1, 2022
Merged
4 tasks
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 1, 2022
Closes mozilla-mobile#26750: add Wallpapers Onboarding dialog
aeb1197
@MozillaNoah MozillaNoah removed the needs:triage Issue needs triage label Sep 1, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 1, 2022
Closes mozilla-mobile#26750: add Wallpapers Onboarding dialog
fbc7e3c
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 1, 2022
Closes mozilla-mobile#26750: fix failing ui tests, fix wallpaper onbo…
9b78661 
…arding displaying conditions
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 1, 2022
Closes mozilla-mobile#26750: add Wallpapers Onboarding dialog
f1496a3
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 1, 2022
Closes mozilla-mobile#26750: fix failing ui tests, fix wallpaper onbo…
1f6143e 
…arding displaying conditions
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 2, 2022
Closes mozilla-mobile#26750: add onboarding to session view, to preve…
6cef8a9 
…nt the wallpapers popup during the initial set up of the Fenix
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 5, 2022
Closes mozilla-mobile#26750: add Wallpapers Onboarding dialog
2dcacb6
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 5, 2022
Closes mozilla-mobile#26750: add wallpapers onboarding conditions
cf418f2
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 5, 2022
Closes mozilla-mobile#26750: add Wallpapers Onboarding dialog
c147882
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 5, 2022
Closes mozilla-mobile#26750: fix ui tests
a392bec
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 5, 2022
Closes mozilla-mobile#26750: refactoring
4edd872
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 5, 2022
Closes mozilla-mobile#26750: add Wallpapers Onboarding dialog
b4232ed
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 5, 2022
Closes mozilla-mobile#26750: fix ui tests
54ad6c6
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 5, 2022
Closes mozilla-mobile#26750: refactoring
b737bdf
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 5, 2022
Closes mozilla-mobile#26750: refactoring
84eb78a
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 9, 2022
Closes mozilla-mobile#26750: fixes according to PR review
ef2b11c
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 9, 2022
Closes mozilla-mobile#26750: add Wallpapers Onboarding dialog
214cc78
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 9, 2022
Closes mozilla-mobile#26750: add Wallpapers Onboarding dialog
05f0559
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 9, 2022
Closes mozilla-mobile#26750: rebase
60b4128
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 9, 2022
Closes mozilla-mobile#26750: fix lint
8cab2a4
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 9, 2022
Closes mozilla-mobile#26750: add Wallpapers Onboarding dialog
c7271eb
@github-actions github-actions bot mentioned this issue Sep 9, 2022
Merged
csadilek added a commit that referenced this issue Sep 11, 2022
@csadilek
Revert "Closes #26750: remove unused files from WallpaperOnboarding"
22e1b9d 
This reverts commit 97987db.
csadilek added a commit that referenced this issue Sep 11, 2022
@csadilek
Revert "Closes #26750: disable wallpapers onboarding in HomeScreenTes…
a78b394 
…t.verifyCustomizeHomepageTest"

This reverts commit 72d7264.
csadilek added a commit that referenced this issue Sep 11, 2022
@csadilek
Revert "Closes #26750: pr review changes"
470b895 
This reverts commit 87334d2.
csadilek added a commit that referenced this issue Sep 11, 2022
@csadilek
Revert "Closes #26750: add ktlintFormat changes"
0b9ce30 
This reverts commit 0ff1401.
csadilek added a commit that referenced this issue Sep 11, 2022
@csadilek
Revert "Closes #26750: add Wallpapers Onboarding dialog"
64e8dcc 
This reverts commit 05b95b6.
rvandermeulen pushed a commit that referenced this issue Sep 11, 2022
@csadilek @rvandermeulen
Revert "Closes #26750: disable wallpapers onboarding in HomeScreenTes…
7ec570e 
…t.verifyCustomizeHomepageTest"

This reverts commit 72d7264.
rvandermeulen pushed a commit that referenced this issue Sep 11, 2022
@csadilek @rvandermeulen
Revert "Closes #26750: pr review changes"
29a36d5 
This reverts commit 87334d2.
rvandermeulen pushed a commit that referenced this issue Sep 11, 2022
@csadilek @rvandermeulen
Revert "Closes #26750: add ktlintFormat changes"
8dd326f 
This reverts commit 0ff1401.
rvandermeulen pushed a commit that referenced this issue Sep 11, 2022
@csadilek @rvandermeulen
Revert "Closes #26750: add Wallpapers Onboarding dialog"
a4692a6 
This reverts commit 05b95b6.
@csadilek csadilek reopened this Sep 11, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 12, 2022
Closes mozilla-mobile#26750: add Wallpapers Onboarding dialog
6fc2bd5
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 12, 2022
Closes mozilla-mobile#26750: add Wallpapers Onboarding dialog
9b9cd16
@mavduevskiy mavduevskiy mentioned this issue Sep 12, 2022
Merged
4 tasks
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Sep 12, 2022
@mergify mergify bot closed this as completed in #26944 Sep 12, 2022
mergify bot pushed a commit that referenced this issue Sep 12, 2022
@mergify
Closes #26750: add Wallpapers Onboarding dialog
65bee4b
@github-actions github-actions bot reopened this Sep 12, 2022
@github-actions github-actions bot removed the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Sep 12, 2022
@mavduevskiy mavduevskiy mentioned this issue Sep 15, 2022
Closed
@MatthewTighe MatthewTighe modified the milestones: 106, 107 Sep 19, 2022
@gabrielluong gabrielluong modified the milestones: 107, 106 Sep 20, 2022
@delia-pop
Copy link

Verified as fixed on Nightly 107.0a1 from 09/22 with Google Pixel 6 (Android 13). The Wallpaper Selection Tool is displayed on the 3rd homepage visit. Wallpapers can be selected and viewed on homepage, the tool can be dismiss by tapping the "X" button, and will also be automatically dismissed after tapping on the "Explore more wallpapers" link and returning to homepage.
The dialog is also locked on Portrait mode.

WallpaperSelectionTool

@delia-pop delia-pop added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 22, 2022
@github-actions github-actions bot mentioned this issue Oct 12, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mavduevskiy mavduevskiy

Labels
eng:qa:verified QA Verified
Projects
None yet
Milestone
106
6 participants
@csadilek @gabrielluong @MatthewTighe @MozillaNoah @delia-pop @mavduevskiy