Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Centre Jump Back In CFR #26777

Closed
gabrielluong opened this issue Sep 1, 2022 · 1 comment · Fixed by #26851
Closed

Centre Jump Back In CFR #26777

gabrielluong opened this issue Sep 1, 2022 · 1 comment · Fixed by #26851
Assignees
@gabrielluong
Labels
eng:qa:verified QA Verified
Milestone
106

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Sep 1, 2022 •
edited
Loading

This was feedback that came from the MR onboarding demo with Product+UX. We want to center the Jump Back in CFR similar to the Synced Tab CFR.

Screen Shot 2022-09-01 at 7 04 04 PM

Screen Shot 2022-09-01 at 10 19 04 PM

┆Issue is synchronized with this Jira Task
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 1, 2022
@gabrielluong gabrielluong self-assigned this Sep 2, 2022
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Sep 7, 2022
@gabrielluong
For mozilla-mobile#26777 - Part 1: Rename SyncCFRPresenter to HomeCFR…
ffae5e8 
…Presenter
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Sep 7, 2022
@gabrielluong
For mozilla-mobile#26777 - Part 2: Refactor the Jump Back In onboardi…
77cab7b 
…ng CFR to use the CFRPopup
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Sep 7, 2022
@github-actions github-actions bot mentioned this issue Sep 7, 2022
Merged
4 tasks
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Sep 7, 2022
@gabrielluong
For mozilla-mobile#26777 - Part 2: Refactor the Jump Back In onboardi…
6b517cc 
…ng CFR to use the CFRPopup
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Sep 7, 2022
@gabrielluong
For mozilla-mobile#26777 - Part 2: Refactor the Jump Back In onboardi…
3daded0 
…ng CFR to use the CFRPopup
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Sep 7, 2022
@gabrielluong
For mozilla-mobile#26777 - Part 2: Refactor the Jump Back In onboardi…
9e76ac7 
…ng CFR to use the CFRPopup
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Sep 7, 2022
@gabrielluong
For mozilla-mobile#26777 - Part 2: Refactor the Jump Back In onboardi…
16bf223 
…ng CFR to use the CFRPopup
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Sep 7, 2022
@gabrielluong
For mozilla-mobile#26777 - Part 2: Refactor the Jump Back In onboardi…
e0216cc 
…ng CFR to use the CFRPopup
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Sep 7, 2022
@gabrielluong
For mozilla-mobile#26777 - Part 2: Refactor the Jump Back In onboardi…
92c625b 
…ng CFR to use the CFRPopup
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Sep 7, 2022
@gabrielluong
For mozilla-mobile#26777 - Part 1: Rename SyncCFRPresenter to HomeCFR…
f6a1a3a 
…Presenter
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Sep 7, 2022
@gabrielluong
For mozilla-mobile#26777 - Part 2: Refactor the Jump Back In onboardi…
acbc9cb 
…ng CFR to use the CFRPopup
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Sep 7, 2022
@gabrielluong
For mozilla-mobile#26777 - Part 2: Refactor the Jump Back In onboardi…
3efd348 
…ng CFR to use the CFRPopup
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Sep 7, 2022
@gabrielluong
For mozilla-mobile#26777 - Part 2: Refactor the Jump Back In onboardi…
0a1a407 
…ng CFR to use the CFRPopup
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Sep 7, 2022
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Sep 7, 2022
@gabrielluong
For mozilla-mobile#26777 - Part 2: Refactor the Jump Back In onboardi…
f1d2e6b 
…ng CFR to use the CFRPopup
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Sep 7, 2022
@gabrielluong
For mozilla-mobile#26777 - Part 2: Refactor the Jump Back In onboardi…
9bce087 
…ng CFR to use the CFRPopup
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Sep 7, 2022
@gabrielluong
For mozilla-mobile#26777 - Part 2: Refactor the Jump Back In onboardi…
fa69ddd 
…ng CFR to use the CFRPopup
@mergify mergify bot closed this as completed in #26851 Sep 8, 2022
mergify bot pushed a commit that referenced this issue Sep 8, 2022
@gabrielluong @mergify
For #26777 - Part 1: Rename SyncCFRPresenter to HomeCFRPresenter
86b62af
mergify bot pushed a commit that referenced this issue Sep 8, 2022
@gabrielluong @mergify
For #26777 - Part 2: Refactor the Jump Back In onboarding CFR to use …
812f073 
…the CFRPopup
@github-actions github-actions bot reopened this Sep 8, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Sep 8, 2022
@github-actions github-actions bot added this to the 106 milestone Sep 8, 2022
@delia-pop
Copy link

Verified as fixed on latest Debug build updated from main 1.0.2237 with Google Pixel 6 (android 13). We will re-test this on Nightly when available.

JumpBackInCFR

@delia-pop delia-pop removed the eng:qa:needed QA Needed label Sep 8, 2022
@delia-pop delia-pop added the eng:qa:verified QA Verified label Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

Labels
eng:qa:verified QA Verified
Projects
None yet
Milestone
106
Development

Successfully merging a pull request may close this issue.

For #26777 - Refactor the Jump Back In onboarding CFR to use the CFRPopup gabrielluong/fenix
2 participants
@gabrielluong @delia-pop