Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

bug: wallpaper onboarding is not shown if any of the thumbnails can not be loaded #26971

Closed
mavduevskiy opened this issue Sep 14, 2022 · 1 comment · Fixed by #26972 or fork-house/fenix#13
Closed

bug: wallpaper onboarding is not shown if any of the thumbnails can not be loaded #26971

mavduevskiy opened this issue Sep 14, 2022 · 1 comment · Fixed by #26972 or fork-house/fenix#13
Assignees
@mavduevskiy
Labels
eng:qa:verified QA Verified
Milestone
106

Comments

@mavduevskiy
Copy link
Contributor

mavduevskiy commented Sep 14, 2022 •
edited by data-sync-user
Loading

Changed logic while refactoring, want to check if there are enough available wallpapers to show the wallpaper onboarding.

┆Issue is synchronized with this Jira Task
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 14, 2022
@mavduevskiy mavduevskiy self-assigned this Sep 14, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 14, 2022
Closes mozilla-mobile#26971: fix wallpaper onboarding display condition
f3fe48a
@mavduevskiy mavduevskiy mentioned this issue Sep 14, 2022
Merged
4 tasks
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Sep 14, 2022
@mavduevskiy mavduevskiy removed the needs:triage Issue needs triage label Sep 14, 2022
@Mugurell Mugurell mentioned this issue Sep 14, 2022
Closed
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 15, 2022
Closes mozilla-mobile#26971: add SessionControlController tests for h…
e5e7c5b 
…andleShowWallpapersOnboardingDialog method
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 15, 2022
Closes mozilla-mobile#26971: fix wallpaper onboarding display condition
7a061ed
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 15, 2022
Closes mozilla-mobile#26971: fix wallpaper onboarding display condition
7f87c62
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 15, 2022
Closes mozilla-mobile#26971: fix naming in SessionControlController t…
286d76d 
…ests
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 15, 2022
Closes mozilla-mobile#26971: fix wallpaper onboarding display condition
1b38d88
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 15, 2022
Closes mozilla-mobile#26971: fix wallpaper onboarding display condition
5135278
@mergify mergify bot closed this as completed in #26972 Sep 15, 2022
mergify bot pushed a commit that referenced this issue Sep 15, 2022
@mergify
Closes #26971: fix wallpaper onboarding display condition
cc30e3d
@github-actions github-actions bot added this to the 106 milestone Sep 15, 2022
@github-actions github-actions bot reopened this Sep 15, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Sep 15, 2022
@MatthewTighe MatthewTighe modified the milestones: 106, 107 Sep 19, 2022
@gabrielluong gabrielluong modified the milestones: 107, 106 Sep 20, 2022
@delia-pop
Copy link

Verified as fixed on Nightly 107.0a1 from 09/23 with Google Pixel 6 (Android 13). The wallpaper selection tool is not displayed if the app was launched without network connection and the thumbnails could not be downloaded. After restoring the network connection and restarting the app, the tool will be displayed on homepage.

@delia-pop delia-pop added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 23, 2022
@github-actions github-actions bot mentioned this issue Oct 20, 2022
Merged
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@mergify
[fenix] Closes mozilla-mobile/fenix#26971: fix wallpaper onboarding d…
ffc81b9 
…isplay condition
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mavduevskiy mavduevskiy

Labels
eng:qa:verified QA Verified
Projects
None yet
Milestone
106
4 participants
@gabrielluong @MatthewTighe @delia-pop @mavduevskiy