Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

adjust wallpaper onboarding design #26973

Closed
mavduevskiy opened this issue Sep 14, 2022 · 1 comment · Fixed by #26974 or fork-house/fenix#13
Closed

adjust wallpaper onboarding design #26973

mavduevskiy opened this issue Sep 14, 2022 · 1 comment · Fixed by #26974 or fork-house/fenix#13
Assignees
@mavduevskiy
Labels
eng:qa:verified QA Verified
Milestone
106

Comments

@mavduevskiy
Copy link
Contributor

mavduevskiy commented Sep 14, 2022 •
edited by data-sync-user
Loading

Had a review round with @Ekaterina Galetski, agreed on these changes:
– change horizontal spacing to 32, keeping vertical as 16;
– remove extra spacing below the bottom button;
– rounded corner should be 8 dp;
– raise background dimming to 0.04;
– check if there is an easy fix for now shadow situation.

┆Issue is synchronized with this Jira Task
@mavduevskiy mavduevskiy self-assigned this Sep 14, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 14, 2022
@mavduevskiy mavduevskiy removed the needs:triage Issue needs triage label Sep 14, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 14, 2022
Closes mozilla-mobile#26973: adjust wallpaper onboarding ui
9f78f64
@mavduevskiy mavduevskiy mentioned this issue Sep 14, 2022
Merged
4 tasks
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Sep 14, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 14, 2022
Closes mozilla-mobile#26973: adjust wallpaper onboarding ui
473c469
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 14, 2022
Closes mozilla-mobile#26973: adjust wallpaper onboarding ui
fda4d33
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 15, 2022
Closes mozilla-mobile#26973: adjust wallpaper onboarding ui
a39c715
@mergify mergify bot closed this as completed in #26974 Sep 15, 2022
mergify bot added a commit that referenced this issue Sep 15, 2022
@mavduevskiy @rvandermeulen @mergify
Closes #26973: adjust wallpaper onboarding ui (#26974)
7fc96b0 
Co-authored-by: mike a <mavduevskiy@gmail.com>
Co-authored-by: Ryan VanderMeulen <rvandermeulen@mozilla.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@github-actions github-actions bot reopened this Sep 15, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Sep 15, 2022
@github-actions github-actions bot added this to the 106 milestone Sep 15, 2022
@MatthewTighe MatthewTighe modified the milestones: 106, 107 Sep 19, 2022
@gabrielluong gabrielluong modified the milestones: 107, 106 Sep 20, 2022
@delia-pop
Copy link

Verified as fixed on Nightly 107.0a1 from 09/23.

1663915985303

@delia-pop delia-pop added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 23, 2022
@github-actions github-actions bot mentioned this issue Oct 20, 2022
Merged
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@mavduevskiy @rvandermeulen @mergify
[fenix] Closes mozilla-mobile/fenix#26973: adjust wallpaper onboardin…
25acaba 
…g ui (mozilla-mobile/fenix#26974)

Co-authored-by: mike a <mavduevskiy@gmail.com>
Co-authored-by: Ryan VanderMeulen <rvandermeulen@mozilla.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mavduevskiy mavduevskiy

Labels
eng:qa:verified QA Verified
Projects
None yet
Milestone
106
4 participants
@gabrielluong @MatthewTighe @delia-pop @mavduevskiy