Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Dead end on "Connected to Sync" #3240

Closed
vladikoff opened this issue Jun 6, 2019 · 7 comments
Closed

Dead end on "Connected to Sync" #3240

vladikoff opened this issue Jun 6, 2019 · 7 comments
Assignees
@topotropic @boek
Labels
eng:qa:verified QA Verified Feature:Sync P1 Current sprint
Milestone
v1.1

Comments

@vladikoff
Copy link
Contributor

vladikoff commented Jun 6, 2019 •
edited by data-sync-user
Loading

cc @grigoryk

┆Issue is synchronized with this Jira Task
@vladikoff vladikoff added the 🐞 bug Crashes, Something isn't working, .. label Jun 6, 2019
@vladikoff
Copy link
Contributor Author

back button also goes back in the form

@grigoryk
Copy link
Contributor

grigoryk commented Jun 6, 2019

@boek we talked about automatically closing this flow on success. What do you think? For this, and other types of issues (like removing the kebab), we'll probably need a custom custom tabs activity.

@vesta0 vesta0 added the P1 Current sprint label Jun 11, 2019
@sblatz
Copy link
Contributor

sblatz commented Jun 11, 2019

@grigoryk when a user hits this "You are now ready to use sync" screen, do we get a callback on the Fenix side?

@boek boek self-assigned this Jun 11, 2019
@boek
Copy link
Contributor

boek commented Jun 13, 2019

@grigoryk @vladikoff @vesta0 I spent some time trying to auto-close this on success but it looks like it will require a significant amount of work that won't be landed in time for code freeze.

@vesta0
Copy link
Collaborator

vesta0 commented Jun 14, 2019

Thanks For investigating @boek. Will add this to the next sprint.

@vesta0 vesta0 removed P1 Current sprint labels Jun 21, 2019
@vesta0 vesta0 added P1 Current sprint and removed 🐞 bug Crashes, Something isn't working, .. labels Jul 3, 2019
@vesta0 vesta0 changed the title [Bug] Dead end on "Connected to Sync" Dead end on "Connected to Sync" Jul 3, 2019
ekager added a commit to ekager/fenix that referenced this issue Jul 4, 2019
@ekager
For mozilla-mobile#3240 - Create AuthCustomTabActivity to fix dead en…
f4eee39 
…d on auth
ekager added a commit to ekager/fenix that referenced this issue Jul 4, 2019
@ekager
For mozilla-mobile#3240 - Create AuthCustomTabActivity to fix dead en…
cbc4e0d 
…d on auth
ekager added a commit to ekager/fenix that referenced this issue Jul 4, 2019
@ekager
For mozilla-mobile#3240 - Create AuthCustomTabActivity to fix dead en…
1444f14 
…d on auth
@vesta0 vesta0 modified the milestones: Q3 Feature Backlog, 1.1 Backlog Jul 5, 2019
ekager added a commit to ekager/fenix that referenced this issue Jul 8, 2019
@ekager
For mozilla-mobile#3240 - Create AuthCustomTabActivity to fix dead en…
2a6b271 
…d on auth
ekager added a commit to ekager/fenix that referenced this issue Jul 8, 2019
@ekager
For mozilla-mobile#3240 - Create AuthCustomTabActivity to fix dead en…
73fb961 
…d on auth
ekager added a commit to ekager/fenix that referenced this issue Jul 8, 2019
@ekager
For mozilla-mobile#3240 - Create AuthCustomTabActivity to fix dead en…
2ae472e 
…d on auth
@vesta0 vesta0 mentioned this issue Jul 9, 2019
Closed
ekager added a commit that referenced this issue Jul 10, 2019
@ekager
For #3240 - Create AuthCustomTabActivity to fix dead end on auth
c6c9818
@vesta0 vesta0 added the eng:qa:needed QA Needed label Jul 10, 2019
@sv-ohorvath
Copy link
Contributor

Can't verify on Android 5& 6 devices for now because of: #3997. I'll leave this here until the crash is fixed.
Otherwise, working fine on HTC10 (Android 8), Galaxy S8 (Android 9)

@sv-ohorvath
Copy link
Contributor

Also verified on HTC Desire 820 (Android 6.0.1). This can be closed now.

@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jul 12, 2019
@colintheshots colintheshots modified the milestones: 1.1 Backlog, v1.1 Jul 23, 2019
@data-sync-user data-sync-user changed the title Dead end on "Connected to Sync" FNX3-16878 ⁃ Dead end on "Connected to Sync" Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-16878 ⁃ Dead end on "Connected to Sync" Dead end on "Connected to Sync" May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@topotropic topotropic

@boek boek

Labels
eng:qa:verified QA Verified Feature:Sync P1 Current sprint
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
10 participants
@vladikoff @topotropic @grigoryk @colintheshots @boek @NotWoods @sv-ohorvath @sblatz @vesta0 @data-sync-user